From: Tay Ray Chuan <rctay89@gmail.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org, Sverre Rabbelier <srabbelier@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] transport-helper: remove duplicate free()
Date: Thu, 3 Dec 2009 07:00:08 +0800 [thread overview]
Message-ID: <be6fef0d0912021500w313ac170m65251f7b8a4fa1de@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0912021120440.14365@iabervon.org>
Hi,
On Thu, Dec 3, 2009 at 12:23 AM, Daniel Barkalow <barkalow@iabervon.org> wrote:
> You need to remove the one in disconnect_helper, because the entire point
> of disconnect_helper as opposed to release_helper is to *not* free that
> memory. If you remove this one, you'll access freed memory in any case
> where the helper has to be quit and restarted.
I see. I guess I should have looked more closely at f2a3715 (Fix
memory leak in helper method for disconnect).
--
Cheers,
Ray Chuan
prev parent reply other threads:[~2009-12-02 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 7:39 [PATCH] transport-helper: remove duplicate free() Tay Ray Chuan
2009-12-02 16:23 ` Daniel Barkalow
2009-12-02 19:06 ` Junio C Hamano
2009-12-02 23:00 ` Tay Ray Chuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d0912021500w313ac170m65251f7b8a4fa1de@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).