git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: "Larry D'Anna" <larry@elder-gods.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
	Daniel Barkalow <barkalow@iabervon.org>,
	"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH v6] add --summary option to git-push and git-fetch
Date: Sun, 31 Jan 2010 20:04:46 +0800	[thread overview]
Message-ID: <be6fef0d1001310404n204ffa31g3cf0a6f170507b3e@mail.gmail.com> (raw)
In-Reply-To: <20100130020548.GA29343@cthulhu>

Hi,

On Sat, Jan 30, 2010 at 10:05 AM, Larry D'Anna <larry@elder-gods.org> wrote:
> --summary will cause git-push to output a one-line of each commit pushed.
> --summary=n will display at most n commits for each ref pushed.
>
> $ git push --dry-run --summary origin :
> To /home/larry/gitsandbox/a
>   80f0e50..5593a38  master -> master
>    > 5593a38 foo
>    > 81c03f8 bar
>
> Fetch works the same way.

I'm sorry for being late to this discussion; I see the time and work
you've put in this and all the previous revisions. But I do have an
objection to implementing this behaviour using the option --summary,
on the grounds of UI-consistency.

I believe git users are already familiar with --summary in git-diff
and git-log, and it might confuse them when the output of --summary
for git-push and git-fetch looks different.

Also, I wonder what is the motivation behind displaying this
information. Perhaps you are including this to produce output for an
IDE? If this is included upstream, then I believe this is the first
instance of such verbose information being displayed. Even a
fast-forward merge (the closest I can think of that matches this)
doesn't show this - I still have to do git log rev1^..rev2 to see.the
intervening revisions (inclusive).

-- 
Cheers,
Ray Chuan

      parent reply	other threads:[~2010-01-31 12:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-03  4:48 [PATCH] add --summary option to git-push and git-fetch Larry D'Anna
2009-07-03  9:20 ` Junio C Hamano
2009-07-07  1:59   ` [PATCH v3] " Larry D'Anna
2009-07-09 18:03     ` Larry D'Anna
2009-07-10  2:24       ` [PATCH v4] " Larry D'Anna
2009-07-10  7:33         ` Stephen Boyd
2009-07-11 17:41           ` Larry D'Anna
2009-07-11 19:05             ` Junio C Hamano
2010-01-30  0:59               ` Larry D'Anna
2010-01-30  1:17                 ` Junio C Hamano
2010-01-30  1:25                   ` Junio C Hamano
2010-01-30  1:19                 ` Junio C Hamano
2010-01-30  1:10               ` [PATCH v5] " Larry D'Anna
2010-01-30  2:05                 ` [PATCH v6] " Larry D'Anna
     [not found]                   ` <7vsk9oysds.fsf@alter.siamese.dyndns.org>
2010-01-30  7:51                     ` Ilari Liusvaara
2010-01-30  8:04                       ` Junio C Hamano
2010-01-30  8:57                         ` Ilari Liusvaara
2010-02-01  0:34                     ` Daniel Barkalow
2010-02-01  0:57                     ` Larry D'Anna
2010-02-04 17:16                       ` Larry D'Anna
2010-02-04 17:25                         ` Junio C Hamano
2010-02-04 17:55                           ` Junio C Hamano
2010-01-31 12:04                   ` Tay Ray Chuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be6fef0d1001310404n204ffa31g3cf0a6f170507b3e@mail.gmail.com \
    --to=rctay89@gmail.com \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ilari.liusvaara@elisanet.fi \
    --cc=larry@elder-gods.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).