From: Tay Ray Chuan <rctay89@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Larry D'Anna" <larry@elder-gods.org>, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Suggestion on git-push --porcelain
Date: Wed, 10 Feb 2010 10:34:00 +0800 [thread overview]
Message-ID: <be6fef0d1002091834i1c4b202cp5afacc326bd1a4d6@mail.gmail.com> (raw)
Hi,
this is regarding the recent patch series from Larry. (I thought
replying to any of the patch messages was appropriate, I couldn't find
a cover-letter, so I'm starting a new thread.)
Around June last year, a patch from Larry was made to add the
--porcelain option, so as to produce machine-readable output regarding
ref status.
The latest patch series goes a step further, and tries to change
output - for example, suppressing user-friendly advice and giving "To:
<destination>".
I think this is an untenable path - adding/suppressing output of
certain messages for porcelain writers, while trying to keep things
fixed enough for porcelain writers to depend on. We will also have to
keep and eye out for future patches from adding fprintfs to stdout and
stderr that may break porcelain scripts.
I believe a better approach would be to prefix messages intended for
porcelain writers. For example, a push session might look like this:
$ git push --porcelain
PORCELAIN To git://foo.com/git/myrepo.git
PORCELAIN uptodate refs/heads/baz:refs/heads/baz 1234ab ba4321
PORCELAIN nonff refs/heads/bar:refs/heads/bar 2345cd 3456de
This is an "positive" approach, in the sense that we don't remove
anything from the current output; we just add more printf("PORCELAIN")
lines to wherever is appropriate.
--
Cheers,
Ray Chuan
next reply other threads:[~2010-02-10 2:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 2:34 Tay Ray Chuan [this message]
2010-02-10 2:57 ` Suggestion on git-push --porcelain Junio C Hamano
2010-02-10 4:54 ` Jeff King
2010-02-10 11:28 ` Tay Ray Chuan
2010-02-10 11:18 ` Tay Ray Chuan
2010-02-10 19:14 ` Junio C Hamano
2010-02-10 3:35 ` Larry D'Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d1002091834i1c4b202cp5afacc326bd1a4d6@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larry@elder-gods.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).