From: Tay Ray Chuan <rctay89@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
"Larry D'Anna" <larry@elder-gods.org>, Jeff King <peff@peff.net>
Subject: Re: Suggestion on git-push --porcelain
Date: Wed, 10 Feb 2010 19:18:32 +0800 [thread overview]
Message-ID: <be6fef0d1002100318v902689xc937cd332ac752b3@mail.gmail.com> (raw)
In-Reply-To: <7vmxzhn6fp.fsf@alter.siamese.dyndns.org>
Hi,
On Wed, Feb 10, 2010 at 10:57 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Tay Ray Chuan <rctay89@gmail.com> writes:
>
>> $ git push --porcelain
>> PORCELAIN To git://foo.com/git/myrepo.git
>> PORCELAIN uptodate refs/heads/baz:refs/heads/baz 1234ab ba4321
>> PORCELAIN nonff refs/heads/bar:refs/heads/bar 2345cd 3456de
>>
>> This is an "positive" approach, in the sense that we don't remove
>> anything from the current output; we just add more printf("PORCELAIN")
>> lines to wherever is appropriate.
>
> Sorry, but I don't see what that would solve. For example, we used not to
> give the destination to the standard output stream, but that line carries
> a necessary information and Larry's series corrects that.
I sense a chicken-and-egg situation here.
Printing a "To: <destination>" to stdout is a correction as far as the
current non-prefixed output scheme is concerned.
If a prefixed scheme (or some other output scheme) is adopted, then
where, or whether, the "To: <destination>" is printed, is not relevant
to porcelain script writers - they just get ignored.
> In your "prefix with PORCELAIN" scheme, such a change will start adding a
> new line "PORCELAIN To ..." that older implementations may not be prepared
> to see.
The original --porcelain patch only "porcelained" the output for ref
updates, such as
= TAB refs/heads/master:refs/heads/master TAB [up to date]
- TAB :refs/heads/foobar TAB [deleted]
...
In addition, the "To: <destination>" patch --porcelain is fairly
recent - I don't think it has left 'pu', has it? Should we worry about
breaking compatibility on something not out yet?
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-02-10 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 2:34 Suggestion on git-push --porcelain Tay Ray Chuan
2010-02-10 2:57 ` Junio C Hamano
2010-02-10 4:54 ` Jeff King
2010-02-10 11:28 ` Tay Ray Chuan
2010-02-10 11:18 ` Tay Ray Chuan [this message]
2010-02-10 19:14 ` Junio C Hamano
2010-02-10 3:35 ` Larry D'Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d1002100318v902689xc937cd332ac752b3@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larry@elder-gods.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).