From: Tay Ray Chuan <rctay89@gmail.com>
To: "Larry D'Anna" <larry@elder-gods.org>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH 3/4] git-push: send "To <remoteurl>" messages to the standard output in --porcelain mode
Date: Fri, 12 Feb 2010 06:54:47 +0800 [thread overview]
Message-ID: <be6fef0d1002111454w10ad965ej72699d1e185d2a9f@mail.gmail.com> (raw)
In-Reply-To: <45357037fd8f928759c9e9064736c62e793b84be.1265694627.git.larry@elder-gods.org>
Hi,
On Tue, Feb 9, 2010 at 1:54 PM, Larry D'Anna <larry@elder-gods.org> wrote:
> diff --git a/transport.c b/transport.c
> index 3846aac..fb653c6 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -675,7 +675,7 @@ static void print_ok_ref_status(struct ref *ref, int porcelain)
> static int print_one_push_status(struct ref *ref, const char *dest, int count, int porcelain)
> {
> if (!count)
> - fprintf(stderr, "To %s\n", dest);
> + fprintf(porcelain ? stdout : stderr, "To %s\n", dest);
>
> switch(ref->status) {
> case REF_STATUS_NONE:
just to check - are debug and user-specific messages (like advice and
info) to be sent, by convention/design/force-of-habit, to stderr? Are
those the "cruft" that has been referred to in other threads?
If that's the case, then perhaps the "To: <destination>" lines should
be sent to both stdout and stderr - stdout, for porcelain scripts as a
"header", and stderr, to help the user make sense of any errors that
occur ("oh, these errors were triggered when pushing to so-and-so
remote").
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-02-11 22:54 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 0:41 [PATCH] fix an error message in git-push so it goes to stderr Larry D'Anna
2010-02-05 15:06 ` Jeff King
2010-02-05 19:34 ` [PATCH 1/3] " Larry D'Anna
2010-02-05 19:34 ` [PATCH 2/3] silence human readable info messages going to stderr from git push --porcelain Larry D'Anna
2010-02-05 20:20 ` Junio C Hamano
2010-02-05 20:30 ` Larry D'Anna
2010-02-05 20:49 ` [PATCH v2 0/3] Larry D'Anna
2010-02-05 20:49 ` [PATCH v2 1/3] fix an error message in git-push so it goes to stderr Larry D'Anna
2010-02-05 20:49 ` [PATCH v2 2/3] clean up some of the output from git push --porcelain Larry D'Anna
2010-02-05 21:07 ` Junio C Hamano
2010-02-05 20:49 ` [PATCH v2 3/3] make git push --dry-run --porcelain exit with status 0 even if updates will be rejected Larry D'Anna
2010-02-05 23:50 ` Tay Ray Chuan
2010-02-08 20:19 ` Larry D'Anna
2010-02-08 20:31 ` [PATCH v3 1/3] git-push: fix an error message so it goes to stderr Larry D'Anna
2010-02-08 20:45 ` Junio C Hamano
2010-02-08 20:31 ` [PATCH v3 2/3] git-push: clean up some of the output from git push --porcelain Larry D'Anna
2010-02-08 20:51 ` Junio C Hamano
2010-02-08 21:13 ` Junio C Hamano
2010-02-08 21:32 ` Jeff King
2010-02-08 22:15 ` Larry D'Anna
2010-02-08 22:21 ` Junio C Hamano
2010-02-08 22:31 ` Larry D'Anna
2010-02-08 22:33 ` [PATCH] git-push: clean up some of the output from git push Larry D'Anna
2010-02-08 22:48 ` [PATCH v3 2/3] git-push: clean up some of the output from git push --porcelain Junio C Hamano
2010-02-08 23:10 ` Larry D'Anna
2010-02-08 23:11 ` Junio C Hamano
2010-02-08 23:44 ` [PATCH] git-push: fix the documentation to explain all the status flags Larry D'Anna
2010-02-09 0:23 ` Junio C Hamano
2010-02-09 0:30 ` Junio C Hamano
2010-02-09 0:45 ` Junio C Hamano
2010-02-09 0:56 ` Larry D'Anna
2010-02-09 1:00 ` Junio C Hamano
2010-02-09 0:54 ` Larry D'Anna
2010-02-09 4:54 ` [PATCH v3 2/3] git-push: clean up some of the output from git push --porcelain Larry D'Anna
2010-02-09 7:31 ` Junio C Hamano
2010-02-09 16:21 ` Larry D'Anna
2010-02-09 17:51 ` t5401-update-hooks test failure Shawn O. Pearce
2010-02-09 19:20 ` Nicolas Pitre
2010-02-09 19:26 ` Shawn O. Pearce
2010-02-09 22:44 ` Junio C Hamano
2010-02-09 23:16 ` Junio C Hamano
2010-02-10 1:29 ` Shawn O. Pearce
2010-02-09 5:48 ` [PATCH v3 2/3] git-push: clean up some of the output from git push --porcelain Larry D'Anna
2010-02-09 5:53 ` [PATCH 1/4] git-push: fix an error message so it goes to stderr Larry D'Anna
2010-02-09 5:54 ` [PATCH 2/4] git-push: squelch advice message if in --porcelain mode Larry D'Anna
2010-02-09 5:54 ` [PATCH 3/4] git-push: send "To <remoteurl>" messages to the standard output " Larry D'Anna
2010-02-11 22:54 ` Tay Ray Chuan [this message]
2010-02-11 23:19 ` Junio C Hamano
2010-02-09 5:54 ` [PATCH 4/4] git-push: make git push --dry-run --porcelain exit with status 0 even if updates will be rejected Larry D'Anna
2010-02-10 5:39 ` [PATCH v3 2/3] git-push: clean up some of the output from git push --porcelain Jeff King
2010-02-10 5:55 ` Larry D'Anna
2010-02-10 10:43 ` Tay Ray Chuan
2010-02-08 22:59 ` Junio C Hamano
2010-02-10 5:49 ` Jeff King
2010-02-11 23:23 ` Junio C Hamano
2010-02-12 0:03 ` Jeff King
2010-02-08 20:31 ` [PATCH v3 3/3] git-push: make git push --dry-run --porcelain exit with status 0 even if updates will be rejected Larry D'Anna
2010-02-08 20:59 ` Junio C Hamano
2010-02-08 21:49 ` Larry D'Anna
2010-02-09 22:25 ` Junio C Hamano
2010-02-10 4:13 ` Larry D'Anna
2010-02-10 4:51 ` [PATCH 4/4] " Larry D'Anna
2010-02-15 17:40 ` [PATCH v3 3/3] " Larry D'Anna
2010-02-15 20:42 ` Junio C Hamano
2010-02-05 19:34 ` [PATCH 3/3] " Larry D'Anna
2010-02-05 19:56 ` Jeff King
2010-02-05 20:05 ` Larry D'Anna
2010-02-05 20:13 ` Jeff King
2010-02-05 19:39 ` [PATCH] fix an error message in git-push so it goes to stderr Larry D'Anna
2010-02-05 19:48 ` Jeff King
2010-02-05 19:50 ` Larry D'Anna
2010-02-05 19:50 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2010-02-26 19:50 [PATCH 0/4] ld/push-porcelain Larry D'Anna
2010-02-26 19:50 ` [PATCH 3/4] git-push: send "To <remoteurl>" messages to the standard output in --porcelain mode Larry D'Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d1002111454w10ad965ej72699d1e185d2a9f@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larry@elder-gods.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).