From: Tay Ray Chuan <rctay89@gmail.com>
To: "Larry D'Anna" <larry@elder-gods.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/4] git-push: make git push --porcelain print "Done"
Date: Sat, 27 Feb 2010 13:22:58 +0800 [thread overview]
Message-ID: <be6fef0d1002262122u1a7396f4jefbab1cb9a484229@mail.gmail.com> (raw)
In-Reply-To: <22ec18ddf7cc504addf7929e2543c60d836d2467.1267245870.git.larry@elder-gods.org>
Hi,
On Sat, Feb 27, 2010 at 12:52 PM, Larry D'Anna <larry@elder-gods.org> wrote:
> The script calling git push --porcelain --dry-run can see clearly from the
> output if an update was rejected. However, it will probably need to distinguish
> this condition from the push failing for other reasons, such as the remote not
> being reachable.
>
> This patch modifies git push --porcelain to print "Done" after the rest of its
> output unless any errors have occurred. For the purpose of the "Done" line,
> knowing a ref will be rejected in a --dry-run does not count as an error.
> Actual rejections in non --dry-run pushes do count as errors.
>
> Signed-off-by: Larry D'Anna <larry@elder-gods.org>
Acked-by: Tay Ray Chuan <rctay89@gmail.com>
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-02-27 5:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 4:52 [PATCH 0/4] ld/push-porcelain Larry D'Anna
2010-02-27 4:52 ` [PATCH 1/4] git-push: fix an advice message so it goes to stderr Larry D'Anna
2010-02-27 4:52 ` [PATCH 2/4] git-push: send "To <remoteurl>" messages to the standard output in --porcelain mode Larry D'Anna
2010-02-27 4:52 ` [PATCH 3/4] git-push: make git push --porcelain print "Done" Larry D'Anna
2010-02-27 5:22 ` Tay Ray Chuan [this message]
2010-02-27 4:52 ` [PATCH 4/4] git-push: add tests for git push --porcelain Larry D'Anna
-- strict thread matches above, loose matches on Subject: below --
2010-02-27 3:59 [PATCH 0/4] ld/push-porcelain Larry D'Anna
[not found] ` <cover.1267243044.git.larry@elder-gods.org>
2010-02-27 3:59 ` [PATCH 3/4] git-push: make git push --porcelain print "Done" Larry D'Anna
2010-02-27 4:19 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d1002262122u1a7396f4jefbab1cb9a484229@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=larry@elder-gods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).