From: Tay Ray Chuan <rctay89@gmail.com>
To: Scott Chacon <schacon@gmail.com>
Cc: git list <git@vger.kernel.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
Daniel Stenberg <daniel@haxx.se>
Subject: Re: [PATCH] Prompt for a username when an HTTP request 401s
Date: Fri, 19 Mar 2010 17:13:37 +0800 [thread overview]
Message-ID: <be6fef0d1003190213m48b6c91dx5cbd489cf798dacc@mail.gmail.com> (raw)
In-Reply-To: <d411cc4a1003182041p67a93bf6i1528a8eaaab5c805@mail.gmail.com>
Hi,
On Fri, Mar 19, 2010 at 11:41 AM, Scott Chacon <schacon@gmail.com> wrote:
> When an HTTP request returns a 401, Git will currently fail with a
> confusing message saying that it got a 401. This changes
> http_request to prompt for the username and password, then return
> HTTP_REAUTH so http_get_strbuf can try again. If it gets a 401 even
> when a user/pass is supplied, http_request will now return HTTP_NOAUTH
> which remote_curl can then use to display a more intelligent error
> message that is less confusing.
(added Daniel to the Cc list)
how are you getting 401s? Recently, git set the CURL_AUTH_ANY option,
so if the correct credentials are passed, curl should have "hid" the
401 from us.
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-03-19 9:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 3:41 [PATCH] Prompt for a username when an HTTP request 401s Scott Chacon
2010-03-19 9:13 ` Tay Ray Chuan [this message]
2010-03-19 9:34 ` Daniel Stenberg
2010-03-19 14:16 ` Shawn O. Pearce
2010-03-19 14:32 ` Shawn O. Pearce
2010-03-19 19:08 ` Scott Chacon
2010-03-19 19:09 ` Shawn O. Pearce
2010-03-19 19:27 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2010-04-01 22:14 Scott Chacon
2010-04-02 6:39 ` Junio C Hamano
2010-04-02 15:43 ` Scott Chacon
2010-04-02 16:11 ` Junio C Hamano
2010-04-01 20:29 Scott Chacon
2010-04-01 21:30 ` Junio C Hamano
2010-04-01 22:06 ` Scott Chacon
2010-03-19 19:17 Scott Chacon
2010-03-18 18:57 Scott Chacon
2010-03-18 19:03 ` Shawn O. Pearce
2010-03-18 23:53 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6fef0d1003190213m48b6c91dx5cbd489cf798dacc@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
--cc=schacon@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).