From: Andrei Rybak <rybak.a.v@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] *: fix typos which duplicate a word
Date: Fri, 11 Jun 2021 11:31:18 +0200 [thread overview]
Message-ID: <beb55a5a-2507-e194-7e3b-92a028210e43@gmail.com> (raw)
In-Reply-To: <xmqq1r99e0ff.fsf@gitster.g>
On 11/06/2021 01:59, Junio C Hamano wrote:
> Andrei Rybak <rybak.a.v@gmail.com> writes:
>
>> Fix typos in documentation and code comments which repeat various words.
>
> Thanks.
>
>> These typos were found by searching using scripts like this:
>>
>> for w in $(grep '^....$' /usr/share/dict/words)
>> do
>> git grep -P "\b$w $w\b"
>> done
>
> This is clarifying and somewhat puzzling at the same time.
>
> It says that doubled words that span across line folding, and
> doubled words that do not have exactly a single space in between,
> have gone undetected (which is fine and may be useful information)
> by showing that it grepped for lines that has doubled words. But it
> also says that you only looked for four-letter words, which I do not
> believe is the case (you fixed "the the", for example), which is
> misleading. The "like this" part can be an excuse for that
Indeed. Basically, it was several scripts with different lists
of words. I considered writing:
for w in <list of words>
do
git grep -P "\b$w $w\b"
done
but opted for an explicit example of a script used, which may
be reused later.
> inaccuracy, but then the whole thing pretty much has already been
> summarized nicely with your first line already, i.e. "which repeate
> various words". If you update it the end part of the sentence to
> "which repeat various words on the same line",
Since v2, I've written a script to also check sentences which span
several lines. I'll send out a v3 with a bunch more fixes.
> then the entire
> paragaph can go without losing clarity.
> Not a huge deal, though.
>
> The changes themselves all look good to me. Thanks. Will apply.
next prev parent reply other threads:[~2021-06-11 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 10:26 [PATCH] fix typos which duplicate a word Andrei Rybak
2021-06-09 15:28 ` Eric Sunshine
2021-06-09 17:31 ` Felipe Contreras
2021-06-10 7:24 ` [PATCH v2] *: " Andrei Rybak
2021-06-10 14:46 ` Felipe Contreras
2021-06-10 23:59 ` Junio C Hamano
2021-06-11 9:31 ` Andrei Rybak [this message]
2021-06-11 11:18 ` [PATCH v3] " Andrei Rybak
2021-06-14 1:11 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2023-01-06 18:25 [PATCH] " Eric Sunshine
2023-01-07 13:56 ` [PATCH v2] " Andrei Rybak
2023-01-08 1:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beb55a5a-2507-e194-7e3b-92a028210e43@gmail.com \
--to=rybak.a.v@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).