Git development
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Christoph Grüninger" <foss@grueninger.de>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: [PATCH v3 3/6] ci: bump actions/github-script from v8 to v9
Date: Thu, 30 Apr 2026 07:34:57 +0000	[thread overview]
Message-ID: <bfbe0db67f5a0454378bd5fd71e2cbc1493bcb59.1777534500.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2097.v3.git.1777534500.gitgitgadget@gmail.com>

From: Johannes Schindelin <johannes.schindelin@gmx.de>

The only use we have of `actions/github-script` is the "skip if the
commit or tree was already tested" step in `main.yml`, which checks
whether an identical tree-SHA was already built successfully. It
currently pins v8; v9 is the latest release.

What v9 changes:

- The `ACTIONS_ORCHESTRATION_ID` environment variable is now
  appended to the HTTP user-agent string. This is transparent to
  our script.
- A new injected `getOctokit` factory lets scripts create
  additional authenticated clients in the same step without
  importing `@actions/github`. We do not use it.
- Two breaking changes affect scripts that either call
  `require('@actions/github')` (fails at runtime, because
  `@actions/github` v9 is now ESM-only) or that shadow the
  implicit `getOctokit` parameter via `const`/`let` (syntax
  error). Our script does neither -- it only uses the pre-supplied
  `github` REST client and `core` helpers -- so the upgrade is
  safe.

Risk analysis: the step is advisory. It sets `enabled=' but skip'`
as an optimization to avoid re-running CI on a tree that was already
tested successfully. Even if the v9 upgrade broke the script, the
surrounding `try { ... } catch (e) { core.warning(e); }` block would
degrade it to a warning and CI would still run normally. In practice
the script continues to work identically on v9.

See also:

- Release notes: https://github.com/actions/github-script/releases
- Compare: https://github.com/actions/github-script/compare/v8...v9

Originally-authored-by: dependabot[bot] <support@github.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 .github/workflows/main.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index da31b10c79..6d7f26e71e 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -63,7 +63,7 @@ jobs:
           echo "skip_concurrent=$skip_concurrent" >>$GITHUB_OUTPUT
       - name: skip if the commit or tree was already tested
         id: skip-if-redundant
-        uses: actions/github-script@v8
+        uses: actions/github-script@v9
         if: steps.check-ref.outputs.enabled == 'yes'
         with:
           github-token: ${{secrets.GITHUB_TOKEN}}
-- 
gitgitgadget


  parent reply	other threads:[~2026-04-30  7:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 12:41 [PATCH 0/4] ci: GitHub Actions updates (brought to you by Dependabot) Johannes Schindelin via GitGitGadget
2026-04-21 12:41 ` [PATCH 1/4] ci: bump microsoft/setup-msbuild from v2 to v3 Johannes Schindelin via GitGitGadget
2026-04-21 12:41 ` [PATCH 2/4] ci: bump actions/{upload,download}-artifact to v7 and v8 Johannes Schindelin via GitGitGadget
2026-04-21 12:41 ` [PATCH 3/4] ci: bump actions/github-script from v8 to v9 Johannes Schindelin via GitGitGadget
2026-04-21 12:41 ` [PATCH 4/4] ci: bump actions/checkout from v5 to v6 Johannes Schindelin via GitGitGadget
2026-04-25 10:58 ` [PATCH v2 0/5] ci: GitHub Actions updates (brought to you by Dependabot) Johannes Schindelin via GitGitGadget
2026-04-25 10:58   ` [PATCH v2 1/5] ci: bump microsoft/setup-msbuild from v2 to v3 Johannes Schindelin via GitGitGadget
2026-04-25 10:58   ` [PATCH v2 2/5] ci: bump actions/{upload,download}-artifact to v7 and v8 Johannes Schindelin via GitGitGadget
2026-04-25 10:58   ` [PATCH v2 3/5] ci: bump actions/github-script from v8 to v9 Johannes Schindelin via GitGitGadget
2026-04-25 10:58   ` [PATCH v2 4/5] ci: bump actions/checkout from v5 to v6 Johannes Schindelin via GitGitGadget
2026-04-25 10:58   ` [PATCH v2 5/5] l10n: bump mshick/add-pr-comment from v2 to v3 Johannes Schindelin via GitGitGadget
2026-04-30  7:34   ` [PATCH v3 0/6] ci: GitHub Actions updates (brought to you by Dependabot) Johannes Schindelin via GitGitGadget
2026-04-30  7:34     ` [PATCH v3 1/6] ci: bump microsoft/setup-msbuild from v2 to v3 Johannes Schindelin via GitGitGadget
2026-04-30  7:34     ` [PATCH v3 2/6] ci: bump actions/{upload,download}-artifact to v7 and v8 Johannes Schindelin via GitGitGadget
2026-04-30  7:34     ` Johannes Schindelin via GitGitGadget [this message]
2026-04-30  7:34     ` [PATCH v3 4/6] ci: bump actions/checkout from v5 to v6 Johannes Schindelin via GitGitGadget
2026-04-30  7:34     ` [PATCH v3 5/6] ci: bump git-for-windows/setup-git-for-windows-sdk from v1 to v2 Johannes Schindelin via GitGitGadget
2026-04-30  7:35     ` [PATCH v3 6/6] l10n: bump mshick/add-pr-comment from v2 to v3 Johannes Schindelin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfbe0db67f5a0454378bd5fd71e2cbc1493bcb59.1777534500.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=foss@grueninger.de \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox