From: Miles Bader <miles@gnu.org>
To: Jeff King <peff@peff.net>
Cc: Eric Raible <raible@nextest.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: RFH: unexpected reflog behavior with --since=
Date: Thu, 10 Nov 2011 20:06:56 +0900 [thread overview]
Message-ID: <buok4785j8v.fsf@dhlpc061.dev.necel.com> (raw)
In-Reply-To: <20111110080851.GA28342@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> The only point would be to leave "--since" to act on the commit
> timestamps, so that you don't have to resort to the external grepping I
> mentioned above. However, I'm not convinced anybody even cares about
> that use case.
>
> I think the behavior you want is much more sensible.
I think there's already confusion in this area, e.g., with @{...} using
reflog dates, but "git log --since" using commit dates. This can be an
easy trap to fall into because _often_ the two have similar granularity
(when you're mostly pushing changes), but not _always_ (when you pull a
big batch of changes).
Soooo, being really really explicit about using reflog dates vs. commit
dates -- and e.g., having option names like "--since" _always_ refer to
commit dates -- would be a good thing, I think...
-Miles
--
Future, n. That period of time in which our affairs prosper, our friends
are true and our happiness is assured.
next prev parent reply other threads:[~2011-11-10 11:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 0:22 RFH: unexpected reflog behavior with --since= Eric Raible
2011-11-09 22:01 ` Jeff King
2011-11-09 22:20 ` Jeff King
2011-11-09 22:26 ` Jeff King
2011-11-10 8:04 ` Eric Raible
2011-11-10 8:08 ` Jeff King
2011-11-10 8:20 ` Eric Raible
2011-11-10 8:31 ` Jay Soffian
2011-11-10 11:06 ` Miles Bader [this message]
2011-11-10 18:18 ` Eric Raible
2011-11-12 6:50 ` Junio C Hamano
2011-11-10 7:48 ` Eric Raible
2011-11-10 7:59 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buok4785j8v.fsf@dhlpc061.dev.necel.com \
--to=miles@gnu.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=raible@nextest.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).