git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rubén Justo" <rjusto@gmail.com>
To: Isoken June Ibizugbe <isokenjune@gmail.com>, git@vger.kernel.org
Cc: christian.couder@gmail.com, gitster@pobox.com
Subject: Re: [PATCH v2] builtin/branch.c: adjust error messages to coding guidelines
Date: Sat, 21 Oct 2023 12:27:34 +0200	[thread overview]
Message-ID: <c0d92716-2add-43c2-945a-cb0c9cb6b6a6@gmail.com> (raw)
In-Reply-To: <331e1ab3-2e8c-497d-a05d-ef197d664188@gmail.com>

On 19-oct-2023 21:20:24, Rubén Justo wrote:

> So, aside from the confusing message, this iteration looks good to me.

Reviewing again the messages in builtin/branch.c, if you finally
re-roll, maybe you want to add: 

diff --git a/builtin/branch.c b/builtin/branch.c
index e7ee9bd0f1..31da889e95 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -777,7 +777,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
        if (!strcmp(head, "HEAD"))
                filter.detached = 1;
        else if (!skip_prefix(head, "refs/heads/", &head))
-               die(_("HEAD not found below refs/heads!"));
+               die(_("HEAD not found below refs/heads"));
 
But if you don't include this nit, that's fine with me.  I still think
the changes you've already made are correct.

Thank you.

  parent reply	other threads:[~2023-10-21 10:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18  5:12 [Outreachy][PATCH] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe
2023-10-18 18:19 ` Rubén Justo
2023-10-18 18:44   ` Junio C Hamano
2023-10-19  8:40   ` [PATCH v2] builtin/branch.c: " Isoken June Ibizugbe
2023-10-19 19:20     ` Rubén Justo
2023-10-20 17:31       ` Junio C Hamano
2023-10-20 17:59         ` Isoken Ibizugbe
2023-10-21 10:31         ` Rubén Justo
2023-10-21 10:27       ` Rubén Justo [this message]
2023-10-20  4:26     ` Isoken Ibizugbe
2023-10-20  9:41       ` Christian Couder
2023-10-20 17:10         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0d92716-2add-43c2-945a-cb0c9cb6b6a6@gmail.com \
    --to=rjusto@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=isokenjune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).