From: "Rubén Justo" <rjusto@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] branch: do not fail a no-op --edit-desc
Date: Sat, 1 Oct 2022 11:15:14 +0200 [thread overview]
Message-ID: <c354947a-06d6-3852-6afe-bd560dd34d6e@gmail.com> (raw)
In-Reply-To: <xmqq7d1lom12.fsf@gitster.g>
Let me add, to my other reply to this..
On 30/9/22 0:26, Junio C Hamano wrote:
>> But.. do we want to implement this this way? Maybe we will have to
>> implement on purpose this feature in some future refactorization?
>
> Absolutely. It is simpler and there is not much downside.
Once I realize this is porcelain, I strongly agree with this.
The TOCTOU might be resolved, perhaps outside the scope of this patch,
warning the user or not allowing two concurrent editions.
Maybe... :-) even I would dig deeper in the TOCTOU, avoiding the call
to git_config_set if no change has been made to the branch description.
Anyway, as it is, it's good, imo. Simple and resolves a confuse error
removing it. Nice.
> The official stance is "if it hurts, do not do it then". The side
> discussion about TOCTOU was to see how much hurt we are making the
> user responsible for, and explaining that it is not that much.
>
next prev parent reply other threads:[~2022-10-01 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 19:15 [PATCH] branch: do not fail a no-op --edit-desc Junio C Hamano
2022-09-28 23:04 ` Rubén Justo
2022-09-28 23:40 ` Junio C Hamano
2022-09-29 21:49 ` Rubén Justo
2022-09-29 22:26 ` Junio C Hamano
2022-09-30 22:59 ` Rubén Justo
2022-10-01 9:15 ` Rubén Justo [this message]
2022-09-30 1:27 ` [PATCH v2] " Junio C Hamano
2022-09-30 10:21 ` Ævar Arnfjörð Bjarmason
2022-09-30 17:01 ` Junio C Hamano
2022-09-30 17:58 ` Ævar Arnfjörð Bjarmason
2022-09-30 18:13 ` Junio C Hamano
2022-09-30 18:06 ` [PATCH v3] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c354947a-06d6-3852-6afe-bd560dd34d6e@gmail.com \
--to=rjusto@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).