git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Adam Brewster" <adam@adambrewster.com>
To: "Jakub Narebski" <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] Created git-basis and modified git-bundle to accept --stdin.
Date: Tue, 24 Jun 2008 11:30:38 -0400	[thread overview]
Message-ID: <c376da900806240830p2a48aff0uaf6f22372fead5ef@mail.gmail.com> (raw)
In-Reply-To: <m3iqvzl091.fsf@localhost.localdomain>

>> Git-basis is a perl script that remembers bases for use by git-bundle.
>> Code from rev-parse was borrowed to allow git-bundle to handle --stdin.
>
> I'd rather you follow git-pack-objects, and use `--revs` for the name
> of this option (or even '--not --revs').  The name `--stdin` might
> imply that you are providing objects names on stdin of git-bundle.
>
> But perhaps I am worrying over nothing.
>

This seems like a fine idea.

> [...]
>> Then you can add the objects in the bundle to the basis, so they won't
>> get included in the next pack like this:
>>
>>  $ git-basis --update my-basis < my-bundle
>
> Why not use "$(git ls-remote my-bundle)" somewhere in the invocation
> creating new bundle instead?
>

You could use "git ls-remote my-bundle | git-basis --update my-basis"
to do the same thing as the command I gave above.

>> I'm sure that my implementation is crap, but I think this is a useful
>> idea.  Anybody agree?  Disagree?
>
> Documentation, please?  Especially that it looks like '--stdin' option
> is a bit tricky...
>

I wanted to test the waters and make sure that someone was at least
vaguely interested in this (no need to document code that is never
going to leave my machine).

I'll prepare another patch with documentation and changing --stdin to
--revs when I get a chance.

Thank you,
Adam Brewster

  reply	other threads:[~2008-06-24 15:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1214273297-8257-1-git-send-email-adambrewster@gmail.com>
     [not found] ` <1214273297-8257-2-git-send-email-adambrewster@gmail.com>
2008-06-24  2:21   ` [PATCH/RFC] Created git-basis and modified git-bundle to accept --stdin Adam Brewster
2008-06-24  8:09     ` Jakub Narebski
2008-06-24 15:30       ` Adam Brewster [this message]
2008-06-24 18:55         ` Jakub Narebski
     [not found]           ` <c376da900806241655q85fc1d9r5bf67096a7930f94@mail.gmail.com>
2008-06-25  0:21             ` Jakub Narebski
2008-06-25  1:14               ` Adam Brewster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c376da900806240830p2a48aff0uaf6f22372fead5ef@mail.gmail.com \
    --to=adam@adambrewster.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).