From: "Adam Brewster" <adambrewster@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v5]
Date: Sat, 5 Jul 2008 22:49:31 -0400 [thread overview]
Message-ID: <c376da900807051949y78161d5dv17f251567ba888da@mail.gmail.com> (raw)
In-Reply-To: <7vskunpyqz.fsf@gitster.siamese.dyndns.org>
>
> Yeah, it is simply a bad taste to use helper in builtin-A from builtin-B.
> More library-ish files such as revision.c are better home for utility
> functions to be shared between builtins and commands.
>
> Here is what I queued.
>
Thank you.
> By the way did you compile test your fix before sending?
>
I ran make and test, but I didn't notice the warnings that prompted
the question. I also forgot to re-check it after re-working the
commits to put everything in order.
> -- >8 --
Thank you again for your help and patience in dealing with my multiple
failed attempts to get this right.
Adam
next prev parent reply other threads:[~2008-07-06 2:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 16:30 [PATCH/v3] bundle.c: added --stdin option to git-bundle Adam Brewster
2008-07-05 16:54 ` Jakub Narebski
2008-07-05 18:15 ` Junio C Hamano
2008-07-05 20:40 ` [PATCH v4 0/3] Adam Brewster
2008-07-05 20:40 ` [PATCH] Move read_revisions_from_stdin from builtin-rev-list.c to revision.c Adam Brewster
2008-07-05 20:40 ` [PATCH] git-bundle: add --stdin Adam Brewster
2008-07-05 20:40 ` [PATCH] Add git-basis.perl to contrib directory Adam Brewster
2008-07-05 20:48 ` [PATCH] Move read_revisions_from_stdin from builtin-rev-list.c to revision.c Miklos Vajna
2008-07-05 21:26 ` [PATCH v5] Adam Brewster
2008-07-05 21:26 ` [PATCH] Move read_revisions_from_stdin from builtin-rev-list.c to revision.c Adam Brewster
2008-07-05 21:26 ` [PATCH] git-bundle: add --stdin Adam Brewster
2008-07-06 0:57 ` Teach git-bundle to read revision arguments from stdin like git-rev-list Junio C Hamano
2008-07-06 14:28 ` Adam Brewster
2008-07-06 14:28 ` [PATCH] git-rev-list: tolerate multiple --stdin options Adam Brewster
2008-07-06 14:28 ` [PATCH] Teach git-bundle to read revision arguments from stdin like Adam Brewster
2008-07-06 1:50 ` [PATCH v5] Junio C Hamano
2008-07-06 2:49 ` Adam Brewster [this message]
2008-07-06 0:57 ` [PATCH] Move read_revisions_from_stdin from builtin-rev-list.c to revision.c Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c376da900807051949y78161d5dv17f251567ba888da@mail.gmail.com \
--to=adambrewster@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).