From: Alexey Shumkin <alex.crezoff@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
Alexey Shumkin <Alex.Crezoff@gmail.com>,
git@vger.kernel.org
Subject: [PATCH v2 1/2] t9901-git-web--browse.sh: Use "write_script" helper
Date: Sat, 26 Jan 2013 04:40:32 +0400 [thread overview]
Message-ID: <c4cde7280a34d1a636c2eb93cfec6ce2f4ac222f.1359160531.git.Alex.Crezoff@gmail.com> (raw)
In-Reply-To: <cover.1359160531.git.Alex.Crezoff@gmail.com>
In-Reply-To: <cover.1359160531.git.Alex.Crezoff@gmail.com>
Use "write_script" helper as suggested by Junio C Hamano.
Also, replace `pwd` with $(pwd) call convention.
Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Alexey Shumkin <Alex.Crezoff@gmail.com>
---
t/t9901-git-web--browse.sh | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/t/t9901-git-web--browse.sh b/t/t9901-git-web--browse.sh
index b0a6bad..b0dabf7 100755
--- a/t/t9901-git-web--browse.sh
+++ b/t/t9901-git-web--browse.sh
@@ -38,12 +38,10 @@ test_expect_success \
test_expect_success \
'browser paths are properly quoted' '
echo fake: http://example.com/foo >expect &&
- cat >"fake browser" <<-\EOF &&
- #!/bin/sh
+ write_script "fake browser" <<-\EOF &&
echo fake: "$@"
EOF
- chmod +x "fake browser" &&
- git config browser.w3m.path "`pwd`/fake browser" &&
+ git config browser.w3m.path "$(pwd)/fake browser" &&
test_web_browse w3m http://example.com/foo
'
--
1.8.1.1.10.g71fa0b7
next prev parent reply other threads:[~2013-01-26 0:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 0:44 [PATCHv3] git-web--browse: avoid the use of eval Chris Packham
2011-10-03 9:57 ` Jeff King
[not found] ` <1321028283-17307-1-git-send-email-Alex.Crezoff@gmail.com>
2011-11-11 18:35 ` [PATCH] git-web--browser: avoid errors in terminal when running Firefox on Windows Jeff King
2011-11-11 19:48 ` Alexey Shumkin
2011-11-11 20:26 ` Jeff King
2013-01-25 14:44 ` Alexey Shumkin
2013-01-25 19:49 ` Junio C Hamano
2013-01-26 0:40 ` [PATCH v2 0/2] git-web--browser: avoid errors in terminal when running Alexey Shumkin
2013-01-26 0:40 ` Alexey Shumkin [this message]
2013-01-26 0:40 ` [PATCH v2 2/2] git-web--browser: avoid errors in terminal when running Firefox on Windows Alexey Shumkin
2013-01-25 22:06 ` [PATCH] " Jeff King
2013-01-25 22:52 ` Shumkin Alexey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4cde7280a34d1a636c2eb93cfec6ce2f4ac222f.1359160531.git.Alex.Crezoff@gmail.com \
--to=alex.crezoff@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).