git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: David Aguilar <davvid@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH RESEND] difftool: word spacing fix
Date: Tue, 21 Sep 2021 14:41:23 +0700	[thread overview]
Message-ID: <c536bd3a-d1ae-a617-c284-dabc9f8c1c0f@gmail.com> (raw)
In-Reply-To: <CAJDDKr4LfTC8h00NCLSu5J=oBTX3LWshrOXMQ7_iBi4RNie9sA@mail.gmail.com>

On 21/09/21 04.26, David Aguilar wrote:
> But!.. and this is a big but... the po/ translations would be broken
> by this change.
> 
> I'm unfamiliar with the policy about changes that affect translations,
> but in general this seems like a situation where we can make things
> easier for the translation team by not leaving behind further work.
> 
> My gut feeling is that this patch would be easier to accept if it also
> updated the po/ translations to fix these typofixes.
> 
> Question for this list -- would that be a separate patch or not? To me
> it seems like it'd all be one patch so that git is never in an
> in-between state.
> 

I think you should see po/README for details.

In other words: we can change translatable strings here as we want, and 
it's the responsibility of l10n teams to update translations to stay up 
to date.

> The following commands show a few places of interest that should also
> be updated.
> 
> $ git grep 'combined diff formats('
> $ git grep 'tool returns a non - zero'

I git-grep-ed that, and nothing outside po/ matched.

-- 
An old man doll... just what I always wanted! - Clara

      reply	other threads:[~2021-09-21  7:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 12:16 [PATCH RESEND] difftool: word spacing fix Bagas Sanjaya
2021-09-20 21:26 ` David Aguilar
2021-09-21  7:41   ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c536bd3a-d1ae-a617-c284-dabc9f8c1c0f@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).