From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Derrick Stolee <dstolee@microsoft.com>,
git@vger.kernel.org, stolee@gmail.com, jonathantanmy@google.com,
sandals@crustytoothpaste.net
Subject: Re: [PATCH 4/3] sha1_name: use bsearch_pack() in unique_in_pack()
Date: Sun, 25 Mar 2018 18:32:03 +0200 [thread overview]
Message-ID: <c56cd048-f0d1-3ed2-6e4e-5063d97071be@web.de> (raw)
In-Reply-To: <xmqqvadkf7rd.fsf@gitster-ct.c.googlers.com>
Am 25.03.2018 um 18:19 schrieb Junio C Hamano:
> René Scharfe <l.s.r@web.de> writes:
>
>> Replace the custom binary search in unique_in_pack() with a call to
>> bsearch_pack(). This reduces code duplication and makes use of the
>> fan-out table of packs.
>>
>> Signed-off-by: Rene Scharfe <l.s.r@web.de>
>> ---
>> This is basically the same replacement as done by patch 3. Speed is
>> less of a concern here -- at least I don't know a commonly used
>> command that needs to resolve lots of short hashes.
>
> Looks correct. Did you find this by eyeballing, or do you have some
> interesting tool you use?
I was looking for SHA1 binary searches using something like this:
git grep -e '/ 2' -e hashcmp -W --all-match
René
next prev parent reply other threads:[~2018-03-25 16:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 20:03 [PATCH] sha1_name: use bsearch_hash() for abbreviations Derrick Stolee
2018-03-20 22:25 ` Jonathan Tan
2018-03-21 13:24 ` Derrick Stolee
2018-03-21 22:42 ` brian m. carlson
2018-03-22 17:40 ` [PATCH v2 0/3] Use " Derrick Stolee
2018-03-22 17:40 ` [PATCH v2 1/3] sha1_name: convert struct min_abbrev_data to object_id Derrick Stolee
2018-03-22 17:40 ` [PATCH v2 2/3] packfile: define and use bsearch_pack() Derrick Stolee
2018-03-22 17:40 ` [PATCH v2 3/3] sha1_name: use bsearch_pack() for abbreviations Derrick Stolee
2018-03-24 16:41 ` [PATCH 4/3] sha1_name: use bsearch_pack() in unique_in_pack() René Scharfe
2018-03-25 16:19 ` Junio C Hamano
2018-03-25 16:32 ` René Scharfe [this message]
2018-03-25 18:21 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c56cd048-f0d1-3ed2-6e4e-5063d97071be@web.de \
--to=l.s.r@web.de \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=sandals@crustytoothpaste.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).