Re: [PATCH v3 1/1] archive-zip: refactor 'path too long' error message to use Q_()

[Phillip Wood <phillip.wood123@gmail.com>]

Hi Keryle

On 20/10/2026 11:22, kerylefondji7@gmail.com wrote:
> From: Keryle Fondji <kerylefondji7@gmail.com>
> 
> @@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,
>   	}
>   
>   	if (pathlen > 0xffff) {
> -		return error(_("path too long (%d chars, SHA1: %s): %s"),
> -				(int)pathlen, oid_to_hex(oid), path);
> +	 return error(Q_("path too long (%d char, SHA1: %s): %s",
> +	   "path too long (%d chars, SHA1: %s): %s",
> +           pathlen),
> +	       (int)pathlen, oid_to_hex(oid), path);

The indentation seems to have got messed up here, the level is wrong and 
it seems to contain spaces as well - if I apply the patch I see

Applying: archive-zip: refactor 'path too long' error message to use Q_()
.git/rebase-apply/patch:17: indent with spaces.
            pathlen),
warning: 1 line applied after fixing whitespace errors.

The code should be wrapped so that lines are not much longer than 80 
characters and should be indented with tabs (possibly followed by a few 
spaces so that the arguments are aligned).

Thanks

Phillip


>   	}
>   
>   	if (S_ISDIR(mode) || S_ISGITLINK(mode)) {