git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alexander Gladysh" <agladysh@gmail.com>
To: "Jeff King" <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: git mergetool vs stash apply
Date: Tue, 20 May 2008 15:16:47 +0400	[thread overview]
Message-ID: <c6c947f60805200416s61b0cc1eqd6d6c804abd15b4@mail.gmail.com> (raw)
In-Reply-To: <20080520090258.GB31703@sigill.intra.peff.net>

On Tue, May 20, 2008 at 1:02 PM, Jeff King <peff@peff.net> wrote:
> On Tue, May 20, 2008 at 12:02:44PM +0400, Alexander Gladysh wrote:
>
>> The git mergetool ignores conflicts by git stash apply:
>>
>> $ git stash apply
>> Auto-merged path/file.ext
>> CONFLICT (content): Merge conflict in path/file.ext
>>
>> $ git mergetool
>> merge tool candidates: kdiff3 kdiff3 tkdiff xxdiff meld gvimdiff
>> opendiff emerge vimdiff
>> No files need merging
>>
>> While path/file.ext do contain merge conflict.
>
> I think there is something else going on, because it _does_ generally
> work. This simple test case should confirm:
>
>  mkdir repo && cd repo && git init
>  echo content >file && git add . && git commit -m one
>  echo changes >>file && git commit -a -m two
>  echo more >>file && git stash
>  git checkout -b other HEAD^
>  echo different changes >>file && git commit -a -m three
>  git stash apply
>  git mergetool
>
> I get:
>  Normal merge conflict for 'file':
>    {local}: modified
>    {remote}: modified
>  Hit return to start merge resolution tool (xxdiff):

Yes, I get the that output on clean repo. And I get that output also
if I use actual conflict data (that is, three snapshots of conflicted
file) instead.

> So there is perhaps something specific about your setup or your conflict
> that is causing mergetool not to work as expected.

Most likely so.

> Can you give us a test case that fails?

No, unfortunately I can not. I was unable to produce a minimal test
case, and I can not share the whole repo.

Alexander.

  reply	other threads:[~2008-05-20 11:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  8:02 git mergetool vs stash apply Alexander Gladysh
2008-05-20  9:02 ` Jeff King
2008-05-20 11:16   ` Alexander Gladysh [this message]
2008-05-20 11:52     ` Jakub Narebski
2008-05-20 12:32       ` Alexander Gladysh
2008-05-20 12:45         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6c947f60805200416s61b0cc1eqd6d6c804abd15b4@mail.gmail.com \
    --to=agladysh@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).