From: Nick Edelen <sirnot@gmail.com>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sam Vilain <sam@vilain.net>,
Michael J Gruber <git@drmicha.warpmail.net>,
Jeff King <peff@peff.net>,
"Shawn O. Pearce" <spearce@spearce.org>,
Andreas Ericsson <exon@op5.se>,
Christian Couder <christian@couder.net>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 6/6 (v4)] support for path name caching in rev-cache
Date: Thu, 20 Aug 2009 14:43:53 +0200 [thread overview]
Message-ID: <c77435a80908200543h74fdb07dm7f30cee4fedef8c5@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0908182313100.6044@xanadu.home>
> Result with the rev-cache populated returns the same number of
> revisions, but not the same amount of data.
> [...]
> So... Why is the leading path component dropped sometimes? That
> explains the output size difference. And the drop is not coherent
> either:
It looks like I didn't realize that tree_entry() returns only the
entry name, and not the full path, which seems like a case of not
thinking, just being logical. The unit tests didn't catch it b/c it
only occurs for root commits, and none of the root commits in the test
had directories involved.
> The object order appears to be rather different. Why so?
The non-commit object order has to be different because they're added
in a different way. It's sorta like vanilla rev-list ordering, except
objects are /only/ appended that are introduced per current commit,
rather than all that haven't been seen yet. It's still a coherent
ordering, and despite the different mechanism I've still enforced the
tag-tree-blob ordering of the normal rev-list.
I've fixed the name issue and added that scenario to the unit tests.
I'll re-upload this last patch in a bit (either minutes if my flight
dosn't leave soon or hours if so).
- Nick
next prev parent reply other threads:[~2009-08-20 12:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 12:31 [PATCH 6/6 (v4)] support for path name caching in rev-cache Nick Edelen
2009-08-18 3:24 ` Nicolas Pitre
2009-08-18 11:31 ` Nick Edelen
2009-08-19 3:52 ` Nicolas Pitre
2009-08-20 12:43 ` Nick Edelen [this message]
2009-08-20 23:22 ` Nick Edelen
2009-08-21 0:05 ` Nicolas Pitre
2009-08-18 11:54 ` Johannes Schindelin
2009-08-18 11:51 ` Nick Edelen
2009-08-21 4:48 ` Nick Edelen
2009-09-07 14:11 ` Nick Edelen
2009-10-02 22:12 ` Nick Edelen
2009-10-19 20:31 ` Nick Edelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c77435a80908200543h74fdb07dm7f30cee4fedef8c5@mail.gmail.com \
--to=sirnot@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian@couder.net \
--cc=exon@op5.se \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
--cc=peff@peff.net \
--cc=sam@vilain.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).