git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Edelen <sirnot@gmail.com>
To: Sam Vilain <sam@vilain.net>
Cc: Junio C Hamano <gitster@pobox.com>, Nicolas Pitre <nico@cam.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Michael J Gruber <git@drmicha.warpmail.net>,
	Jeff King <peff@peff.net>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Andreas Ericsson <exon@op5.se>,
	Christian Couder <christian@couder.net>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 5/6 (v4)] full integration of rev-cache into git,  completed test suite
Date: Wed, 9 Sep 2009 00:24:22 +0200	[thread overview]
Message-ID: <c77435a80909081524i493603efhb32dee77c1e7223b@mail.gmail.com> (raw)
In-Reply-To: <1252357564.5969.4.camel@maia.lan>

> ^^ You don't need to write comments like "This patch"; in the history
> such words are meaningless.

I had meant to delete that...

> "tweak" ?

Yeah I had modified the messages and didn't replace the additional
info I deleted.  It's not really important, as it's modified again
(for the last time) in the name-related patch, but here it's revised
to take advantage of the size storage.

>>  - more fluid handling of damaged cache slices
>
> What does this mean?

That it remembers/is aware of bad slices, instead of dumbly attempting
to load them upon each commit.

> This is quite a long commit message.  Is the above detail all useful?
> Can it be split into one patch for each of the above integrations?

Erm, I suppose they could be split, but the changes to revision and
list-objects aren't very big, so I figured it'd be easier/cleaner to
just put everything required for smooth integration into a single
patch.  I dunno, it dosn't seem hugely necessary; the bits modifying
git code are relatively small and already obviously seperate in the
patch.

  reply	other threads:[~2009-09-08 22:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17 12:31 [PATCH 5/6 (v4)] full integration of rev-cache into git, completed test suite Nick Edelen
2009-08-18 11:51 ` Nick Edelen
2009-08-21  4:48   ` Nick Edelen
2009-09-07 14:11     ` Nick Edelen
2009-09-07 21:06       ` Sam Vilain
2009-09-08 22:24         ` Nick Edelen [this message]
2009-09-30  7:53       ` Chris Johnsen
2009-09-30  8:09         ` Johannes Sixt
2009-10-02 22:12   ` Nick Edelen
2009-10-19 20:30 ` Nick Edelen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c77435a80909081524i493603efhb32dee77c1e7223b@mail.gmail.com \
    --to=sirnot@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=christian@couder.net \
    --cc=exon@op5.se \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nico@cam.org \
    --cc=peff@peff.net \
    --cc=sam@vilain.net \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).