From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] t: handle EOF in test_copy_bytes()
Date: Sun, 16 Jul 2017 13:10:50 +0200 [thread overview]
Message-ID: <c79eeaec-64e6-db27-d590-ab94a47394d1@web.de> (raw)
In-Reply-To: <20170716104718.i4nyphyzqh2mzhxt@sigill.intra.peff.net>
Am 16.07.2017 um 12:47 schrieb Jeff King:
> On Sun, Jul 16, 2017 at 06:45:32AM -0400, Jeff King wrote:
>
>> I was playing with SANITIZE=undefined after René's patches to see how
>> far we had left to go. I forgot to turn off sha1dc, which causes most
>> programs to die due to the unaligned loads. That means git-archive in
>> t5000 generates no output, triggering the bug. :)
>
> And I was pleased to see that after setting OPENSSL_SHA1, the answer to
> "how far" is "we are there". Yay.
True with GCC, but not with Clang 3.9. A patch for alignment issues in
dir.c is coming up..
René
next prev parent reply other threads:[~2017-07-16 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 10:45 [PATCH] t: handle EOF in test_copy_bytes() Jeff King
2017-07-16 10:47 ` Jeff King
2017-07-16 11:10 ` René Scharfe [this message]
2017-07-16 11:21 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c79eeaec-64e6-db27-d590-ab94a47394d1@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox