From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Paul Tan <pyokagan@gmail.com>,
git@vger.kernel.org, Stefan Beller <sbeller@google.com>,
Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH 2/2] pull: handle --log=<n>
Date: Wed, 13 May 2015 14:23:21 +0200 [thread overview]
Message-ID: <c8dc145fcc56d38e04fc0e07ceb34999@www.dscho.org> (raw)
In-Reply-To: <vpqlhgszujc.fsf@anie.imag.fr>
Hi Matthieu,
On 2015-05-13 11:38, Matthieu Moy wrote:
> Paul Tan <pyokagan@gmail.com> writes:
>
>> - --log|--no-log)
>> - log_arg=$1 ;;
>> + --log|--log=*|--no-log)
>> + log_arg="$1" ;;
>
> I think you actually don't need the double quotes here (var=$value works
> even if $value has spaces IIRC), but they don't harm and I prefer having
> them.
I am far from a shell expert, but IIRC "$1" converts all whitespace to single spaces. In general, you therefore want to quote arguments, just in case.
Ciao,
Dscho
next prev parent reply other threads:[~2015-05-13 12:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 9:17 [PATCH 0/2] teach git pull to handle --log=<n> Paul Tan
2015-05-13 9:17 ` [PATCH 1/2] t5524: test --log=1 limits shortlog length Paul Tan
2015-05-13 9:17 ` [PATCH 2/2] pull: handle --log=<n> Paul Tan
2015-05-13 9:38 ` Matthieu Moy
2015-05-13 12:23 ` Johannes Schindelin [this message]
2015-05-13 20:03 ` Matthieu Moy
2015-05-13 9:40 ` [PATCH 0/2] teach git pull to " Matthieu Moy
2015-05-14 17:11 ` Junio C Hamano
2015-05-15 11:15 ` Paul Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8dc145fcc56d38e04fc0e07ceb34999@www.dscho.org \
--to=johannes.schindelin@gmx.de \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=pyokagan@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).