git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dragan Simic <dsimic@manjaro.org>
To: Isoken June Ibizugbe <isokenjune@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [Outreachy][PATCH 0/1] builtin/branch.c: ammend die() error message
Date: Wed, 11 Oct 2023 17:34:17 +0200	[thread overview]
Message-ID: <c98dd0b5988f9889ee4c2b5d4e645839@manjaro.org> (raw)
In-Reply-To: <20231011152424.6957-1-isokenjune@gmail.com>

On 2023-10-11 17:24, Isoken June Ibizugbe wrote:
> This patch improves the consistency and clarity of error messages
> across Git commands. It adheres to Git's Coding Guidelines for error
> messages:
> 
> - Error messages no longer end with a full stop.
> - Capitalization is avoided in error messages.
> - Error messages lead with a description of the issue, enhancing 
> readability.
> 
> Signed-off-by: Isoken June Ibizugbe <isokenjune@gmail.com>

When there's only one patch and not a series, there's no need for a 
cover letter, and the description of the patch actually needs to go into 
the patch itself, so it can be latter pulled into the repository as part 
of the patch submission.

> Isoken June Ibizugbe (1):
>   branch.c: ammend error messages for die()
> 
>  builtin/branch.c | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)

  parent reply	other threads:[~2023-10-11 15:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 15:24 [Outreachy][PATCH 0/1] builtin/branch.c: ammend die() error message Isoken June Ibizugbe
2023-10-11 15:24 ` [PATCH 1/1] branch.c: ammend error messages for die() Isoken June Ibizugbe
2023-10-11 17:29   ` Junio C Hamano
2023-10-11 18:04   ` Rubén Justo
2023-10-11 19:10     ` Junio C Hamano
2023-10-12  5:31     ` Isoken Ibizugbe
2023-10-11 15:34 ` Dragan Simic [this message]
     [not found]   ` <CAJHH8bGOSXNNYfOCkS=ck8r-=Mbq62Rs1c4NsgFWYD999kNfRw@mail.gmail.com>
2023-10-11 15:46     ` [Outreachy][PATCH 0/1] builtin/branch.c: ammend die() error message Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c98dd0b5988f9889ee4c2b5d4e645839@manjaro.org \
    --to=dsimic@manjaro.org \
    --cc=git@vger.kernel.org \
    --cc=isokenjune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).