From: "Martin Storsjö" <martin@martin.st>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] diff --no-index: fix -R with stdin
Date: Mon, 11 Sep 2023 22:20:33 +0300 (EEST) [thread overview]
Message-ID: <c9d3184f-24ac-af75-f31e-aa63c788bfb3@martin.st> (raw)
In-Reply-To: <22fdfa3b-f90e-afcc-667c-705fb7670245@web.de>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Sun, 10 Sep 2023, René Scharfe wrote:
> When -R is given, queue_diff() swaps the mode and name variables of the
> two files to produce a reverse diff. 1e3f26542a (diff --no-index:
> support reading from named pipes, 2023-07-05) added variables that
> indicate whether files are special, i.e named pipes or - for stdin.
> These new variables were not swapped, though, which broke the handling
> of stdin with with -R. Swap them like the other metadata variables.
>
> Reported-by: Martin Storsjö <martin@martin.st>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> Great bug report, thank you!
Thanks for the extremely swift response and fix!
// Martin
prev parent reply other threads:[~2023-09-11 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 20:42 Regression in git diff with stdin, with -R Martin Storsjö
2023-09-09 22:12 ` [PATCH] diff --no-index: fix -R with stdin René Scharfe
2023-09-10 10:00 ` Phillip Wood
2023-09-10 18:41 ` Taylor Blau
2023-09-11 19:04 ` Junio C Hamano
2023-09-11 19:20 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9d3184f-24ac-af75-f31e-aa63c788bfb3@martin.st \
--to=martin@martin.st \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).