From: Mark Lodato <lodatom@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
Robert Shearman <robertshearman@gmail.com>,
Ben Walton <bwalton@artsci.utoronto.ca>
Subject: Re: [PATCH] Disable OpenSSL SHA1 implementation by default
Date: Thu, 25 Feb 2010 23:11:59 -0500 [thread overview]
Message-ID: <ca433831002252011r3d3459a2xca7535300cd6630f@mail.gmail.com> (raw)
In-Reply-To: <20100222112326.GA21929@coredump.intra.peff.net>
On Mon, Feb 22, 2010 at 6:23 AM, Jeff King <peff@peff.net> wrote:
> On Mon, Feb 22, 2010 at 05:08:14AM -0600, Jonathan Nieder wrote:
>
>> The OpenSSL SHA-1 routine is about as fast as block-sha1, but linking
>> to libcrypto slows down the startup of git commands by an appreciable
>> amount. Use the BLK_SHA1 implementation by default instead.
>
> What is your definition of "about as fast"? I benchmarked up to a 20%
> slow-down a while back:
For what it's worth, here are my numbers from running git-fsck on my
x86-64 machine. It appears that BLK-SHA1 is slightly faster. If you
know a better benchmark to run, let me know. Perhaps it would be good
to write some sort of suite to test this, and let people post their
results to some website.
make git-fsck
./git-fsck 66.75s user 0.28s system 99% cpu 1:07.17 total
./git-fsck 66.70s user 1.28s system 99% cpu 1:08.06 total
./git-fsck 66.77s user 0.63s system 99% cpu 1:07.42 total
make BLK_SHA1=1 git-fsck
./git-fsck 65.60s user 0.65s system 99% cpu 1:06.26 total
./git-fsck 65.39s user 0.65s system 99% cpu 1:06.06 total
./git-fsck 65.24s user 1.36s system 100% cpu 1:06.60 total
Core 2 Duo E6300 1.86 GHz (2MB L2 cache), 2GB memory
Ubuntu 9.10 x86-64, gcc 4.4.1, git v1.7.0-90-g251a495
next prev parent reply other threads:[~2010-02-26 4:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 11:08 [PATCH] Disable OpenSSL SHA1 implementation by default Jonathan Nieder
2010-02-22 11:23 ` Jeff King
2010-02-22 11:55 ` Jonathan Nieder
2010-02-26 4:11 ` Mark Lodato [this message]
2010-02-26 9:36 ` Jeff King
2010-02-26 21:33 ` Mark Lodato
2010-02-26 22:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca433831002252011r3d3459a2xca7535300cd6630f@mail.gmail.com \
--to=lodatom@gmail.com \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=nico@fluxnic.net \
--cc=peff@peff.net \
--cc=robertshearman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).