git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>
To: "Jakub Narebski" <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: gitweb and remote branches
Date: Thu, 30 Aug 2007 11:09:05 +0200	[thread overview]
Message-ID: <cb7bb73a0708300209g564284f8w900db693485acdb7@mail.gmail.com> (raw)
In-Reply-To: <200708301016.17552.jnareb@gmail.com>

On 8/30/07, Jakub Narebski <jnareb@gmail.com> wrote:
> On Thu, 30 August 2007, Giuseppe Bilotta wrote:
> > What I had in mind was a way to modify 'heads' view with a boolean
> > option that enable/disabled remotes view.
>
> That is a good idea. We can for example use extra_options ('opt')
> parameter to pass 'refs/remotes' etc. to 'heads' view. Or we can
> use some new CGI parameter. Or just make it configurable in gitweb
> configuration, with per repository override, i.e. make it into
> %feature.

For the time being I've made it into a project-overridable %feature.
(It was easier to set up than I though.) I do like the idea of having
it also as an additional CGI parameter.

> > For their visualizations, I
> > had in mind a split 'heads' secion, with the lhs being as it is now,
> > and the rhs having the remotes.
>
> Care to provide some ascii-art mockup?

(monospace view)

[heads]                | [remotes]
date headname links    | date headname links
date headname links    | date headname links

or a variation thereof. However, I have a 1600x1200 screen so not
everybody might be confortable with such a view.

> What I had in mind was for 'summary' view (*bold*, _underline_):
>
>   [heads]
>   27 min ago       _gitweb-allheads_   shortlog | log | tree
>   24 hours ago     master              shortlog | log | tree
>
>   [remotes]
>   *origin*
>     24 hours ago    man        shortlog | log | tree
>     24 hours ago    html       shortlog | log | tree
>     24 hours ago    next       shortlog | log | tree
>     24 hours ago    pu         shortlog | log | tree
>     24 hours ago    _master_   shortlog | log | tree
>     2 weeks ago     maint      shortlog | log | tree
>     2 weeks ago     todo       shortlog | log | tree
>
> and similarly for 'remotes' view (or 'heads').

I think I like yours better. I had just implemented split
remotes/heads list in summary view, so I'll keep working towards your
idea.

> Note that we remove remote name from remote branch name, although
> we can leave it as is (i.e. origin/man vs. man),

Yes, I'll work on this next.

> and that we filter
> out HEAD if it points to existing branch, marking one of the branches
> as current instead.

I don't know if I'll be able to implement this, but I'll try :)

> > However, I wasn't sure if such a view would have been appreciated, so
> > I went for the merged view and used the spans to make the heads appear
> > as they do in the shortlog, as a clear way to mark which ones were
> > local and which ones were remote.
>
> On
>
>   http://oblomov.dnsalias.org/git?p=git.git;a=heads
>
> I don't see any difference between formatting of remote heads and local
> branches.

Indeed, I removed the thing when I started working on the repo.

> > However, it's even harder if you consider
> > that even the latest git-svn plops all the svn-converted refs straight
> > into refs/remotes and not in a subdir such as refs/remotes/svn.
>
> Or refs/svn. I think that dumping remotes directly into refs/remotes
> and not to refs/remotes/<remote> is a bug (also in git-svn).

I think so too. I'll report it as a bug to the git-svn developers.

> > I'll be working on it here
> >
> > http://oblomov.dnsalias.org/git?p=git.git;a=shortlog;h=gitweb-allheads
> >
> > and keep you posted on my progress.
>
> You can also make a git fork at http://repo.or.cz

Oh, interesting. Just clicking on the 'fork' link in
http://repo.or.cz/w/git/gitweb.git and filling up the form?

I'll set that up as a mirror shortly.


-- 
Giuseppe "Oblomov" Bilotta

  reply	other threads:[~2007-08-30  9:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-27 22:24 gitweb and remote branches Giuseppe Bilotta
2007-08-27 23:29 ` Jakub Narebski
     [not found] ` <cb7bb73a0708280253y7d31f347yb84a40982d59d9d2@mail.gmail.com>
     [not found]   ` <cb7bb73a0708280453k4315e80ej170238a52e66dcb6@mail.gmail.com>
2007-08-29 22:01     ` Jakub Narebski
2007-08-30  7:18       ` Giuseppe Bilotta
2007-08-30  8:16         ` Jakub Narebski
2007-08-30  9:09           ` Giuseppe Bilotta [this message]
2007-08-30 21:07           ` Junio C Hamano
2007-08-30 23:09             ` Giuseppe Bilotta
2007-08-30 23:53               ` Jakub Narebski
2007-08-30 23:59                 ` Giuseppe Bilotta
2007-08-31  2:15                   ` Giuseppe Bilotta
2007-08-31 10:54                     ` [PATCH 01/14] gitweb: get remotes too when getting heads list Giuseppe Bilotta
2007-08-31 10:55                     ` [PATCH 02/14] gitweb: make remote heads in heads list optional Giuseppe Bilotta
2007-08-31 10:55                     ` [PATCH 03/14] gitweb: git_get_heads_list now accepts an optional list of refs Giuseppe Bilotta
2007-08-31 10:55                     ` [PATCH 04/14] gitweb: separate heads and remotes list in summary view Giuseppe Bilotta
2007-08-31 10:59                     ` [PATCH 05/14] gitweb: allow refs passed to git_heads_body to use a name different from the hash name Giuseppe Bilotta
2007-08-31 11:05                     ` [PATCH 06/14] gitweb: git_split_heads_body function Giuseppe Bilotta
2007-08-31 11:18                     ` [PATCH 07/14] gitweb: use CSS to style split head lists Giuseppe Bilotta
2007-08-31 11:18                       ` [PATCH 08/14] gitweb: add 'remotes' action as a synonym for git_heads() Giuseppe Bilotta
2007-08-31 11:18                         ` [PATCH 09/14] gitweb: split heads list in head view if appropriate Giuseppe Bilotta
2007-08-31 11:19                     ` [PATCH 10/14] gitweb: display HEAD in heads list when detached Giuseppe Bilotta
2007-08-31 11:19                       ` [PATCH 11/14] gitweb: git_is_head_detached() function Giuseppe Bilotta
2007-08-31 11:19                         ` [PATCH 12/14] gitweb: add HEAD to list of shortlog refs if detached Giuseppe Bilotta
2007-08-31 11:19                           ` [PATCH 13/14] gitweb: CSS style and refs mark for detached HEAD Giuseppe Bilotta
2007-08-31 11:19                             ` [PATCH 14/14] gitweb: minor whitespace cleanups Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb7bb73a0708300209g564284f8w900db693485acdb7@mail.gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).