From: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>
To: "Kevin Ballard" <kevin@sb.org>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] diff: add ruby funcname pattern
Date: Sat, 2 Aug 2008 07:41:37 +0200 [thread overview]
Message-ID: <cb7bb73a0808012241s80a06fq1ac54a3350169f6c@mail.gmail.com> (raw)
In-Reply-To: <0C57339C-50EF-4199-A14B-AFF04C92EF87@sb.org>
On Sat, Aug 2, 2008 at 2:31 AM, Kevin Ballard <kevin@sb.org> wrote:
>
> As a Ruby user, the regex for the funcname looks fine to me.
What is your opinion about the anonymous code blocks?
I've been thinking that another possibility could be to have two ruby
funcnames, a simpler one (the one I presented) that only has 'named'
blocks, and a more thorough one that also matches up anonymous blocks.
User could then choose which one to use in their code by having
gitattributes such as *.rb diff=ruby or *.rb diff=ruby-full (or
whatever else).
I'm not sure this would be a sensible policy though.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2008-08-02 5:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 7:21 [PATCH] diff: add ruby funcname pattern Giuseppe Bilotta
2008-08-01 7:30 ` Junio C Hamano
2008-08-01 8:11 ` Giuseppe Bilotta
2008-08-01 8:20 ` Junio C Hamano
2008-08-01 8:39 ` Giuseppe Bilotta
2008-08-01 14:41 ` Jeff King
2008-08-02 0:31 ` Kevin Ballard
2008-08-02 3:50 ` Junio C Hamano
2008-08-02 5:41 ` Giuseppe Bilotta [this message]
2008-08-02 5:47 ` Kevin Ballard
2008-08-02 6:06 ` Giuseppe Bilotta
2008-08-02 11:39 ` Johannes Schindelin
2008-08-02 11:50 ` Giuseppe Bilotta
2008-08-02 15:37 ` Lee Marlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0808012241s80a06fq1ac54a3350169f6c@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).