From: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, "Jakub Narebski" <jnareb@gmail.com>
Subject: Re: [PATCHv2] gitweb: refactor input parameters parse/validation
Date: Fri, 10 Oct 2008 19:33:40 +0200 [thread overview]
Message-ID: <cb7bb73a0810101033y3741df2dy88a64e72cbc3b8b0@mail.gmail.com> (raw)
In-Reply-To: <20081010150108.GC29829@spearce.org>
On Fri, Oct 10, 2008 at 5:01 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:
>> +sub validate_action {
>> + my $input = shift || return undef;
>> + return undef unless exists $actions{$action};
>> + return $action;
>> +}
>
> Shouldn't $action here be $input?
Urgh. Yes, yes it should. Good catch. Should I resend?
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2008-10-10 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 17:19 [PATCH] gitweb: refactor input parameters parse/validation Giuseppe Bilotta
2008-10-07 10:57 ` Jakub Narebski
2008-10-07 12:42 ` Giuseppe Bilotta
2008-10-07 14:39 ` Jakub Narebski
2008-10-08 9:10 ` Giuseppe Bilotta
2008-10-08 9:45 ` Jakub Narebski
2008-10-08 9:26 ` [PATCHv2] " Giuseppe Bilotta
2008-10-10 8:37 ` Jakub Narebski
2008-10-10 15:01 ` Shawn O. Pearce
2008-10-10 17:33 ` Giuseppe Bilotta [this message]
2008-10-10 18:42 ` [PATCHv3] " Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0810101033y3741df2dy88a64e72cbc3b8b0@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).