From: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>
To: "Matt Kraai" <kraai@ftbfs.org>
Cc: git@vger.kernel.org
Subject: Re: [RFCv4 1/3] gitweb: add patch view
Date: Sun, 7 Dec 2008 10:52:38 +0100 [thread overview]
Message-ID: <cb7bb73a0812070152j3c7ecc51r9f19523cfef44d39@mail.gmail.com> (raw)
In-Reply-To: <20081207060430.GE4357@ftbfs.org>
On Sun, Dec 7, 2008 at 7:04 AM, Matt Kraai <kraai@ftbfs.org> wrote:
> Howdy,
>
> Why do you check $patch_max at the start of git_commitdiff instead of
> at the start of hunk which opens git-format-patch? It seems like it
> would be clearer to check it later, at some small loss of efficiency.
Subsequent patches use the check to add a link to the nav bar, so it
reduces code shift from patch to patch 8-)
--
Giuseppe "Oblomov" Bilotta
next parent reply other threads:[~2008-12-07 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081207060430.GE4357@ftbfs.org>
2008-12-07 9:52 ` Giuseppe Bilotta [this message]
2008-12-06 15:02 [RFCv4 0/3] gitweb: patch view Giuseppe Bilotta
2008-12-06 15:02 ` [RFCv4 1/3] gitweb: add " Giuseppe Bilotta
2008-12-15 13:17 ` Jakub Narebski
2008-12-15 13:48 ` Giuseppe Bilotta
2008-12-15 13:58 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0812070152j3c7ecc51r9f19523cfef44d39@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=kraai@ftbfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).