From: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>
To: "Jakub Narebski" <jnareb@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Petr Baudis" <pasky@suse.cz>
Subject: Re: [PATCHv5 2/3] gitweb: add patches view
Date: Thu, 18 Dec 2008 20:57:43 +0100 [thread overview]
Message-ID: <cb7bb73a0812181157r20b0cbc3t290e32454a435b0c@mail.gmail.com> (raw)
In-Reply-To: <200812181915.48556.jnareb@gmail.com>
On Thu, Dec 18, 2008 at 7:15 PM, Jakub Narebski <jnareb@gmail.com> wrote:
>
> Just a though, but does it really take much sense to have "patch" and
> "patches" views handled in git_commitdiff? I can understand in the
> first version, where it was more about better 'commitdiff_plain', but
> I wonder about now, where patch(es) view is something between git show
> and log_plain format... Wouldn't it be simpler to use separate
> subroutine, for example git_format_patch or something?
I don't feel like much has changed since the beginning when IYO it
made sense to have it part of commitdiff, honestly
--
Giuseppe "Oblomov" Bilotta
prev parent reply other threads:[~2008-12-18 19:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 10:11 [PATCHv5 0/3] gitweb: patch view Giuseppe Bilotta
2008-12-16 10:11 ` [PATCHv5 1/3] gitweb: add " Giuseppe Bilotta
2008-12-16 10:11 ` [PATCHv5 2/3] gitweb: add patches view Giuseppe Bilotta
2008-12-16 10:11 ` [PATCHv5 3/3] gitweb: link to patch(es) view in commit(diff) and (short)log view Giuseppe Bilotta
2008-12-18 6:09 ` [PATCHv5 2/3] gitweb: add patches view Junio C Hamano
2008-12-18 9:33 ` Jakub Narebski
2008-12-18 16:23 ` Giuseppe Bilotta
2008-12-18 17:28 ` Jakub Narebski
2008-12-18 19:15 ` Junio C Hamano
2008-12-18 19:44 ` Jakub Narebski
2008-12-18 18:15 ` Jakub Narebski
2008-12-18 19:57 ` Giuseppe Bilotta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0812181157r20b0cbc3t290e32454a435b0c@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).