From: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>
To: "Joey Hess" <joey@kitenet.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: support the rel=vcs microformat
Date: Wed, 7 Jan 2009 19:03:04 +0100 [thread overview]
Message-ID: <cb7bb73a0901071003m77482a99wf6f3988beb5b5e78@mail.gmail.com> (raw)
In-Reply-To: <20090107155023.GA16540@gnu.kitenet.net>
On Wed, Jan 7, 2009 at 4:50 PM, Joey Hess <joey@kitenet.net> wrote:
> Giuseppe Bilotta wrote:
>> In this patch you do NOT add titles to the rel=vcs links, which means that
>> everything works fine only if there is a single URL for each project. If a
>> project has different URLs, it's going to appear multiple times as _different_
>> projects to a spec-compliant reader.
>>
>> A possible solution would be to make @git_url_list into a map keyed by the
>> project name and having the description and repo URL(s) as values.
>
> Yes. I considered doing that, but didn't immediatly see a way to get the
> project description w/o additional overhead (of looking it up a second
> time).
The solution I have in mind would be something like this: in summary
or projects list view (which are the views in which we put the links,
and also the views in which we loop up the repo URL and the
description anyway), you fill up former @git_url_list (now
%project_metadata) looking up the repo description and URLs. You then
use this information both in the link tag and in the appropriate
places for the visible part of the webpage: you don't have a
significant overhead, because you're just moving the project
description retrieval early on.
You probably want to refactor the code by making a
git_get_project_metadata() sub that extends the current URL retrieval
by retrieving description and URLs. The routine can then be used
either for one or for all the projects, as needed.
> Thanks for the feedback. There are some changes happening to the
> microformat that should make gitweb's job slightly easier, I'll respin
> the patch soon.
Let me know about this too, I very much like the idea of this microformat.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-01-07 18:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 4:25 [PATCH] gitweb: support the rel=vcs microformat Joey Hess
2009-01-07 12:30 ` Giuseppe Bilotta
2009-01-07 15:50 ` Joey Hess
2009-01-07 18:03 ` Giuseppe Bilotta [this message]
2009-01-07 18:41 ` Joey Hess
2009-01-10 0:01 ` Jakub Narebski
2009-01-07 18:45 ` Joey Hess
2009-01-07 19:02 ` Joey Hess
2009-01-07 23:24 ` [PATCH] gitweb: support the rel=vcs-* microformat Joey Hess
2009-01-08 7:56 ` Giuseppe Bilotta
2009-01-08 19:54 ` gitweb index performance (Re: [PATCH] gitweb: support the rel=vcs-* microformat) Joey Hess
2009-01-08 23:53 ` J.H.
2009-01-09 0:16 ` Miklos Vajna
2009-01-09 0:19 ` Johannes Schindelin
2009-01-09 0:26 ` J.H.
2009-01-10 1:44 ` Jakub Narebski
2009-01-10 1:11 ` Jakub Narebski
2009-01-10 1:04 ` [PATCH] gitweb: support the rel=vcs-* microformat Jakub Narebski
2009-01-10 0:52 ` Jakub Narebski
2009-01-10 0:03 ` [PATCH] gitweb: support the rel=vcs microformat Jakub Narebski
2009-01-09 23:56 ` Jakub Narebski
2009-01-09 23:49 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0901071003m77482a99wf6f3988beb5b5e78@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=joey@kitenet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).