Re: [PATCHv4] gitweb: make static files accessible with PATH_INFO

[Giuseppe Bilotta <giuseppe.bilotta@gmail.com>]

On Wed, Jan 28, 2009 at 2:47 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> On Wed, 28 Jan 2009, Junio C Hamano wrote:
>> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>>
>> > When PATH_INFO is defined,
>
> I other words: when using PATH_INFO gitweb URL

Notice that gitweb accepts PATH_INFO even whe it's not set to produce them

>> > static files such as the default CSS or the
>> > shortcut icon are not accessible beyond the summary page (e.g. in
>> > shortlog or commit view).
>
> To be more exact: if static files, such as the default CSS (and also
> other stylesheets, if defined), the gitweb favicon / shortcut icon,
> or the gitweb logo locations (URIs) are defined using relative URL
> with relative path (and default Makefile rule to generate gitweb.cgi
> uses basenames like 'gitweb.css', which are relative paths) _THEN_
> those static files are not accessible beyond 'summary' and projects
> list view (e.g. in 'shortlog' or 'commit' view).

I'll rewrite the commit message.

>> >
>> > Fix this by adding a <base> tag pointing to the script's own URL.
>
> Which defines base URL for all relative links in gitweb.

(is this one really necessary)

> /Note that this makes the document hierarchy non-portable, but I don't
> think we care.../

In what sense it becomes non-portable?

>> > +   if ($ENV{'PATH_INFO'}) {
>> > +           print "<base href=\"$my_url\" />\n";
>> > +   }
>>
>> Perhaps this is a stupid question, but is $my_url already safe to include
>> in the output without any further quoting at this point in the codepath?
>
> Hmmmm... to be safe we probably should use either esc_url($my_url) here
> (like in git_feed subroutine).

I"ll do that.

-- 
Giuseppe "Oblomov" Bilotta