From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH v3] gitweb: fix wrong base URL when non-root DirectoryIndex
Date: Sat, 14 Feb 2009 15:29:49 +0100 [thread overview]
Message-ID: <cb7bb73a0902140629pa1ad038pe898aa0d804d0707@mail.gmail.com> (raw)
In-Reply-To: <200902141104.35042.jnareb@gmail.com>
On Sat, Feb 14, 2009 at 11:04 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>
> P.S. I wonder why Giuseppe's patch failed to apply, and failed
> to do fallback 3-way merge...
Because it depends on an additional quoting fix that I sent to the
mailing list but that apparently didn't get through.
> - print '<base href="'.esc_url($my_url).'" />\n';
> + print '<base href="'.esc_url($base_url).'" />\n';
The quoting fix was here: double quotes are needed because otherwise
the \n gets in literally. We can probably squash it with this patch.
Gimme a sec and I'll cook it up again.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-02-14 14:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 21:11 [PATCH] gitweb: fix wrong base URL when non-root DirectoryIndex Giuseppe Bilotta
2009-02-12 22:03 ` Jakub Narebski
2009-02-13 7:36 ` Giuseppe Bilotta
2009-02-13 7:40 ` Giuseppe Bilotta
2009-02-13 8:45 ` Jakub Narebski
2009-02-14 2:14 ` Junio C Hamano
2009-02-14 2:42 ` Jakub Narebski
2009-02-14 8:52 ` Giuseppe Bilotta
2009-02-14 9:30 ` Junio C Hamano
2009-02-14 10:04 ` [PATCH v3] " Jakub Narebski
2009-02-14 14:29 ` Giuseppe Bilotta [this message]
2009-02-15 9:18 ` [PATCHv4] " Giuseppe Bilotta
2009-02-15 19:33 ` [PATCH v3] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0902140629pa1ad038pe898aa0d804d0707@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).