git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] StGit patch series import
Date: Mon, 25 May 2009 01:03:38 +0200	[thread overview]
Message-ID: <cb7bb73a0905241603r4949abb5g1a9e861aba40c6fe@mail.gmail.com> (raw)
In-Reply-To: <fabb9a1e0905241557l403037f6p7c1df1f587cb9cf7@mail.gmail.com>

On Mon, May 25, 2009 at 12:57 AM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> Heya,
>
> On Mon, May 25, 2009 at 00:53, Giuseppe Bilotta
> <giuseppe.bilotta@gmail.com> wrote:
>> This is an interesting solution. And git-am could call git-munge
>> automatically before feeding the patches to mailinfo, replacing
>>  git mailinfo $keep $utf8 "$dotest/msg" "$dotest/patch" \
>>      <"$dotest/$msgnum" >"$dotest/info"
>> with
>>  git munge "$dotest/$msgnum" | git mailinfo etc
>
> I was thinking the other way around, so that 'git am' doesn't need to
> be modified.
>
> Behind the scenes, git munge "$dotest/$msgnum" does something like:
> 1. munge the file so that it's in the appropriate format
> 2. dispatch to 'git am' with the munged file
> 3. profit

But then the name munge would not be descriptive of what the command
does. If git am is to be left untouched, I would rather then have
something like git import-patches that accepts patches in 'any'
format, expanding StGIT series into the respective patches and
transforming everything into mbox format, invoking am on the final
result. But I see no particular reason why git-am shouldn't be able to
handle all this by itself


-- 
Giuseppe "Oblomov" Bilotta

  reply	other threads:[~2009-05-24 23:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-24  7:19 [PATCH 0/2] StGit patch series import Giuseppe Bilotta
2009-05-24 20:49 ` Junio C Hamano
2009-05-24 21:43   ` Giuseppe Bilotta
2009-05-24 21:55     ` Sverre Rabbelier
2009-05-24 22:04       ` Giuseppe Bilotta
2009-05-24 22:05         ` Sverre Rabbelier
2009-05-24 22:02     ` Junio C Hamano
2009-05-24 22:18       ` Giuseppe Bilotta
2009-05-24 22:28         ` Sverre Rabbelier
2009-05-24 22:53           ` Giuseppe Bilotta
2009-05-24 22:57             ` Sverre Rabbelier
2009-05-24 23:03               ` Giuseppe Bilotta [this message]
2009-05-25  6:39                 ` Junio C Hamano
2009-05-25  7:19                   ` Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb7bb73a0905241603r4949abb5g1a9e861aba40c6fe@mail.gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).