git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv2 2/4] git-am foreign patch support: autodetect some patch  formats
Date: Wed, 27 May 2009 10:19:41 +0200	[thread overview]
Message-ID: <cb7bb73a0905270119w30d1053ah6427363b9cbe4428@mail.gmail.com> (raw)
In-Reply-To: <7vd49vj9mb.fsf@alter.siamese.dyndns.org>

On Wed, May 27, 2009 at 9:19 AM, Junio C Hamano <gitster@pobox.com> wrote:

> Don't make the case unnecessary too deep nor redundant.
>
>        ...
>        read l3
>        case "$l1" in
>        "From "* | "From: "* )
>                patch_format=mbox
>                ;;

Oh thanks. I think I had tried the construct this way but failed to
make * and | work together. Looks like I was doing it wrong.

-- 
Giuseppe "Oblomov" Bilotta

      reply	other threads:[~2009-05-27  8:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26  0:38 [PATCHv2 0/4] git-am support for foreign patches Giuseppe Bilotta
2009-05-26  0:38 ` [PATCHv2 1/4] git-am foreign patch support: introduce patch_format Giuseppe Bilotta
2009-05-26  0:38   ` [PATCHv2 2/4] git-am foreign patch support: autodetect some patch formats Giuseppe Bilotta
2009-05-26  0:38     ` [PATCHv2 3/4] git-am foreign patch support: StGIT support Giuseppe Bilotta
2009-05-26  0:38       ` [PATCHv2 4/4] git-am: refactor 'cleaning up and aborting' Giuseppe Bilotta
2009-05-27  7:19         ` Junio C Hamano
2009-05-27  7:19       ` [PATCHv2 3/4] git-am foreign patch support: StGIT support Junio C Hamano
2009-05-27  8:29         ` Giuseppe Bilotta
2009-05-27 20:50           ` Junio C Hamano
2009-05-27  7:19     ` [PATCHv2 2/4] git-am foreign patch support: autodetect some patch formats Junio C Hamano
2009-05-27  8:19       ` Giuseppe Bilotta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb7bb73a0905270119w30d1053ah6427363b9cbe4428@mail.gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).