Re: [PATCHv6 5/8] gitweb: gravatar url cache

[Giuseppe Bilotta <giuseppe.bilotta@gmail.com>]

2009/6/27 Jakub Narebski <jnareb@gmail.com>:
> On Thu, 25 Jun 2009, Giuseppe Bilotta wrote:
>
>> Views which contain many occurrences of the same email address (e.g.
>> shortlog view) benefit from not having to recalculate the MD5 of the
>> email address every time.
>
> It would be nice to have some benchmarks comparing performance before
> and after this patch.

Indeed it would.

Oh, you mean I should provide them? 8-D

(I'll see if I can get around it this weekend)

> I guess it is not worth it to _not_ use cache for few avatars views
> such as 'commit', 'commitdiff', in the future also 'tag' view, isn't it?

I would say not.

> BTW. http://www.gravatar.com/site/implement/url recommends
> http://www.gravatar.com/avatar/3b3be63a4c2a439b013787725dfce802 rather than
> http://www.gravatar.com/avatar.php?gravatar_id=3b3be63a4c2a439b013787725dfce802
> you use, following http://www.gravatar.com/site/implement/perl

I think the perl code there is just obsolete (the /avarar/ thing is
more recent). I'll update to the new one because it's more compact.

-- 
Giuseppe "Oblomov" Bilotta