Re: [PATCHv7 3/9] gitweb: use git_print_authorship_rows in 'tag' view too

[Giuseppe Bilotta <giuseppe.bilotta@gmail.com>]

2009/6/27 Jakub Narebski <jnareb@gmail.com>:
> On Sat, 27 June 2009, Giuseppe Bilotta wrote:
>
>> parse_tag has to be adapted to use the hash keys expected by
>> git_print_authorship_rows, which is not a problem since git_tag
>> is the only user of this sub.
>
> Nitpick: I think that with s/has/had/ (past tense) and
> s/, which/. This/ (split paragraph into two sentences)
> it would read better.

I can do that.

> Sidenote: I wonder if it would be worth doing to factor out code dealing
> with extracting data from (parsing) author/committer/tagger object headers.
> Probably not worth it...

It might be worth it, but I'd say we can leave it to some other time ;-)

> I wonder why we used and use 'author' instead of 'tagger'...

The upside of using 'author' is that the tag can then be dealt with
just like any other commit by the rest of the code, I think. I don't
know if this benefit is actually used anywhere in the code.


-- 
Giuseppe "Oblomov" Bilotta