From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCHv8 6/7] gitweb: picon avatar provider
Date: Tue, 30 Jun 2009 22:50:42 +0200 [thread overview]
Message-ID: <cb7bb73a0906301350u6c44628ds5bbee6b77abf7983@mail.gmail.com> (raw)
In-Reply-To: <200906302223.23190.jnareb@gmail.com>
2009/6/30 Jakub Narebski <jnareb@gmail.com>:
> On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
>> - # Currently only gravatars are supported, but other forms such as
>> - # picons can be added by putting an else up here and defining $url
>> + # Other providers can be added by extending the if chain, defining $url
>> # as needed. If no variant puts something in $url, we assume avatars
>> # are completely disabled/unavailable.
>
> I see that you have updated comments too.
Well, I tried to address all the points that were raised during review 8-)
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-06-30 20:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 22:00 [PATCHv8 0/7] gitweb: avatar support Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 1/7] gitweb: refactor author name insertion Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 2/7] gitweb: uniform author info for commit and commitdiff Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 3/7] gitweb: use git_print_authorship_rows in 'tag' view too Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 4/7] gitweb: (gr)avatar support Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 5/7] gitweb: gravatar url cache Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 6/7] gitweb: picon avatar provider Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 7/7] gitweb: add empty alt text to avatar img Giuseppe Bilotta
2009-06-30 20:29 ` Jakub Narebski
2009-06-30 20:23 ` [PATCHv8 6/7] gitweb: picon avatar provider Jakub Narebski
2009-06-30 20:50 ` Giuseppe Bilotta [this message]
2009-06-30 20:18 ` [PATCHv8 5/7] gitweb: gravatar url cache Jakub Narebski
2009-06-30 20:38 ` Junio C Hamano
2009-06-30 20:52 ` Giuseppe Bilotta
2009-06-30 20:16 ` [PATCHv8 4/7] gitweb: (gr)avatar support Jakub Narebski
2009-06-30 20:10 ` [PATCHv8 3/7] gitweb: use git_print_authorship_rows in 'tag' view too Jakub Narebski
2009-06-30 20:04 ` [PATCHv8 2/7] gitweb: uniform author info for commit and commitdiff Jakub Narebski
2009-06-30 20:04 ` [PATCHv8 1/7] gitweb: refactor author name insertion Jakub Narebski
2009-06-30 20:23 ` Giuseppe Bilotta
2009-06-30 21:08 ` Jakub Narebski
2009-06-30 23:15 ` Giuseppe Bilotta
2009-07-01 7:41 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0906301350u6c44628ds5bbee6b77abf7983@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).