From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>,
Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCHv8 5/7] gitweb: gravatar url cache
Date: Tue, 30 Jun 2009 22:52:26 +0200 [thread overview]
Message-ID: <cb7bb73a0906301352t123aee01naa80e8fa41011d99@mail.gmail.com> (raw)
In-Reply-To: <7vprcl78zm.fsf@alter.siamese.dyndns.org>
On Tue, Jun 30, 2009 at 10:38 PM, Junio C Hamano<gitster@pobox.com> wrote:
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> +# Rather than recomputing the url for an email multiple times, we cache it
>> +# after the first hit. This gives a visible benefit in views where the avatar
>> +# for the same email is used repeatedly (e.g. shortlog).
>> +# The cache is shared by all avatar engines (currently gravatar only), which
>> +# are free to use it as preferred. Since only one avatar engine is used for any
>> +# given page, there's no risk for cache conflicts.
>
> Is it "any given page", or "any given e-mail"?
It's 'page' as in HTML file served by the script. I couldn't find a
better way to express that.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-06-30 20:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 22:00 [PATCHv8 0/7] gitweb: avatar support Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 1/7] gitweb: refactor author name insertion Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 2/7] gitweb: uniform author info for commit and commitdiff Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 3/7] gitweb: use git_print_authorship_rows in 'tag' view too Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 4/7] gitweb: (gr)avatar support Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 5/7] gitweb: gravatar url cache Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 6/7] gitweb: picon avatar provider Giuseppe Bilotta
2009-06-29 22:00 ` [PATCHv8 7/7] gitweb: add empty alt text to avatar img Giuseppe Bilotta
2009-06-30 20:29 ` Jakub Narebski
2009-06-30 20:23 ` [PATCHv8 6/7] gitweb: picon avatar provider Jakub Narebski
2009-06-30 20:50 ` Giuseppe Bilotta
2009-06-30 20:18 ` [PATCHv8 5/7] gitweb: gravatar url cache Jakub Narebski
2009-06-30 20:38 ` Junio C Hamano
2009-06-30 20:52 ` Giuseppe Bilotta [this message]
2009-06-30 20:16 ` [PATCHv8 4/7] gitweb: (gr)avatar support Jakub Narebski
2009-06-30 20:10 ` [PATCHv8 3/7] gitweb: use git_print_authorship_rows in 'tag' view too Jakub Narebski
2009-06-30 20:04 ` [PATCHv8 2/7] gitweb: uniform author info for commit and commitdiff Jakub Narebski
2009-06-30 20:04 ` [PATCHv8 1/7] gitweb: refactor author name insertion Jakub Narebski
2009-06-30 20:23 ` Giuseppe Bilotta
2009-06-30 21:08 ` Jakub Narebski
2009-06-30 23:15 ` Giuseppe Bilotta
2009-07-01 7:41 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0906301352t123aee01naa80e8fa41011d99@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).