From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Robert Fitzsimons <robfitz@273k.net>
Subject: Re: [PATCHv1bis 1/2] git apply: option to ignore whitespace differences
Date: Thu, 2 Jul 2009 23:05:40 +0200 [thread overview]
Message-ID: <cb7bb73a0907021405r15639624y7fdbb2a0aed85b27@mail.gmail.com> (raw)
In-Reply-To: <7vws6q3in0.fsf@alter.siamese.dyndns.org>
On Thu, Jul 2, 2009 at 11:00 PM, Junio C Hamano<gitster@pobox.com> wrote:
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> I do wonder what makes the patch 'unreviewable', since I assume that
>> doesn't mean just 'does not include the refactoring I requested'.
>
> Ok, unreviewable may not be the word, and "it is apparent that the patch
> has not been well thought through" is the word I would want.
>
> IOW, it really should have been marked as "[RFC/PATCH]".
Ah yes, I keep forgetting about that. I remembered it on the very
first try (actually, I wrote PATCH/RFC), but then I forgot about it in
the next rounds.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-07-02 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 17:48 [PATCHv1bis 0/2] git apply: cope with whitespace differences Giuseppe Bilotta
2009-07-02 17:48 ` [PATCHv1bis 1/2] git apply: option to ignore " Giuseppe Bilotta
2009-07-02 17:48 ` [PATCHv1bis 2/2] git apply: preserve original whitespace with --ignore-whitespace Giuseppe Bilotta
2009-07-02 18:27 ` [PATCHv1bis 1/2] git apply: option to ignore whitespace differences Junio C Hamano
2009-07-02 19:02 ` Giuseppe Bilotta
2009-07-02 19:28 ` Giuseppe Bilotta
2009-07-02 19:45 ` Junio C Hamano
2009-07-02 20:33 ` Giuseppe Bilotta
2009-07-02 21:00 ` Junio C Hamano
2009-07-02 21:05 ` Giuseppe Bilotta [this message]
2009-07-02 23:55 ` Junio C Hamano
2009-07-03 6:40 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0907021405r15639624y7fdbb2a0aed85b27@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robfitz@273k.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).