From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: gitweb: buggy 'commitdiff_plain' output
Date: Fri, 10 Jul 2009 19:38:11 +0200 [thread overview]
Message-ID: <cb7bb73a0907101038t10494806k64380a5e33f1bc16@mail.gmail.com> (raw)
In-Reply-To: <200907101933.39424.jnareb@gmail.com>
On Fri, Jul 10, 2009 at 7:33 PM, Jakub Narebski<jnareb@gmail.com> wrote:
> Actually the problem is deeper; both 'commitdiff' and 'commitdiff_plain'
> try to do two things at once: an equivalent of "git show <commit>" _and_
> equivalent of "git diff <commit 1> <commit 2>"... and they fail.
I think the time might have come to break backwards compatibility and
fix commitdiff view once and for all ... of course we would have to
choose HOW to fix it ...
For single commits, we could have commitdiff = commit + diff and
commitdiff_plain = patch.
For multiple commits, we could have commitdiff(_plain) output a list
of subjects for each commit involved, + the output of git diff.
How does that sound? (read?)
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-07-10 17:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 17:04 gitweb: buggy 'commitdiff_plain' output Linus Torvalds
2009-07-10 17:33 ` Jakub Narebski
2009-07-10 17:38 ` Giuseppe Bilotta [this message]
2009-07-10 21:05 ` Linus Torvalds
2009-07-10 21:50 ` Jakub Narebski
2009-07-10 17:34 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0907101038t10494806k64380a5e33f1bc16@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).