git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Nicolas Sebrecht <ni.s@laposte.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-am: less strong format "mbox" detection
Date: Tue, 14 Jul 2009 09:16:24 +0200	[thread overview]
Message-ID: <cb7bb73a0907140016r4807c008h9c98f76200e9c3a5@mail.gmail.com> (raw)
In-Reply-To: <bb3a84e2b817268a88832dc7043383e4b91a3df3.1247553623.git.ni.s@laposte.net>

On Tue, Jul 14, 2009 at 8:40 AM, Nicolas Sebrecht<ni.s@laposte.net> wrote:
> Thunderbird (v1.* at least) likes to start e-mails with "X-Account-Key:".
> Also, I have some emails starting with "Return-Path:" or ""Delivered-To:".
>
> Signed-off-by: Nicolas Sebrecht <ni.s@laposte.net>
> ---
>  git-am.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-am.sh b/git-am.sh
> index d64d997..d10a8e0 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -169,7 +169,7 @@ check_patch_format () {
>                read l2
>                read l3
>                case "$l1" in
> -               "From "* | "From: "*)
> +               "From "* | "From: "* | "X-Account-Key:"* | "Return-Path:"* | "Delivered-To:"*)

Nitpick: for consistency, should we either expect a space after the
colon also in the new keys, or not expect i in the From: key either. I
don't think the RFC requires a space, but most clients probably add
it.

-- 
Giuseppe "Oblomov" Bilotta

  reply	other threads:[~2009-07-14  7:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14  6:40 [PATCH] git-am: less strong format "mbox" detection Nicolas Sebrecht
2009-07-14  7:16 ` Giuseppe Bilotta [this message]
2009-07-14  8:20   ` [PATCH] " Nicolas Sebrecht
2009-07-14  8:35     ` Johannes Sixt
2009-07-14  8:42     ` Junio C Hamano
2009-07-14 12:23       ` Nicolas Sebrecht
2009-07-15  5:52         ` [PATCH v2] git-am: fix maildir support regression for unordered headers in emails Nicolas Sebrecht
2009-07-15  7:27           ` Junio C Hamano
2009-07-15 12:54             ` Derek Fawcus
2009-07-15 16:19               ` [PATCH v2] " Nicolas Sebrecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb7bb73a0907140016r4807c008h9c98f76200e9c3a5@mail.gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ni.s@laposte.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).