From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Stephen Boyd <bebarino@gmail.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [RFC/PATCH] gitweb: linkify author/committer names with search
Date: Tue, 13 Oct 2009 21:41:42 +0200 [thread overview]
Message-ID: <cb7bb73a0910131241t7220a3c2q16e99a8fc62dd29a@mail.gmail.com> (raw)
In-Reply-To: <4AD4C94A.9010909@gmail.com>
On Tue, Oct 13, 2009 at 8:39 PM, Stephen Boyd <bebarino@gmail.com> wrote:
> Giuseppe Bilotta wrote:
>> On Monday 12 October 2009 08:19, Stephen Boyd wrote:
>>> The problem is I can't get it to work with UTF-8 characters. I'm not sure
>>> if it's my system or not, so I'm just posting here to see if others
>>> experience the same problem and if there's interest.
>>
>> Does it work if you use CGI::escape() on the author names when filling
>> the searchtext?
>
> This doesn't seem to work. Now I get %25 in front of the escaped
> characters. For example, a space is now %25%20.
>
> Can you reproduce my problem locally?
Reproduced, debugged, patch incoming (the problem is not in your patch
but in esc_param).
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-10-13 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 6:19 [RFC/PATCH] gitweb: linkify author/committer names with search Stephen Boyd
2009-10-12 23:42 ` Junio C Hamano
2009-10-13 0:31 ` Stephen Boyd
2009-10-13 10:26 ` Giuseppe Bilotta
2009-10-13 18:39 ` Stephen Boyd
2009-10-13 19:41 ` Giuseppe Bilotta [this message]
2009-10-13 20:16 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a0910131241t7220a3c2q16e99a8fc62dd29a@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).