git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jakub Narebski <jnareb@gmail.com>,
	git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Johan Herland <johan@herland.net>
Subject: Re: [PATCH 1/4] gitweb: notes feature
Date: Fri, 5 Feb 2010 00:38:51 +0100	[thread overview]
Message-ID: <cb7bb73a1002041538m64c6a6b3p5ee8bbaf0d78457@mail.gmail.com> (raw)
In-Reply-To: <7vaavo90ic.fsf@alter.siamese.dyndns.org>

On Thu, Feb 4, 2010 at 10:03 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> AFAIU, the note code on the core side already creates a fan-out structure
> when notes tree gets large (see recent "What's cooking"; the series is
> parked in 'pu' but that is primarily because we are in feature freeze); it
> is not just "inherently not robust" but is much closer to "broken from day
> one" ;-).  Otherwise I wouldn't have wasted time to point it out.

Ouch, I hadn't considered that, indeed.

> Your code is a very good proof-of-concept, though.

Thanks. I guess at this point a proper implementation can wait for the
necessary core support functions.

> Regarding support of multiple notes hierarchies, listing, etc.
>
> See for example:
>
>  http://thread.gmane.org/gmane.comp.version-control.git/138079/focus=138128
>
> I expect more ideas from needs by end-user would come, as we gain
> experience with using notes in real projects.  You will certainly find
> some other needs of your own, like the "not an environment but a command
> line option" which Jakub mentioned, and "multiple hierarchies" like both
> you and I found need for.  Share them and let us together make the notes
> mechanism nicer to use.

Collecting those ideas together would also help define some sort of
roadmap, or at least have a clear idea of what's needed, to help drive
the design of the features themselves. Maybe we could start a TODO
page on the wiki collecting these ideas?

-- 
Giuseppe "Oblomov" Bilotta

  reply	other threads:[~2010-02-04 23:39 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-04 16:18 [PATCH 0/4] gitweb: preliminary notes support Giuseppe Bilotta
2010-02-04 16:18 ` [PATCH 1/4] gitweb: notes feature Giuseppe Bilotta
2010-02-04 16:33   ` Junio C Hamano
2010-02-04 16:46     ` Junio C Hamano
2010-02-04 17:21       ` Jakub Narebski
2010-02-04 20:08         ` Giuseppe Bilotta
2010-02-04 21:03           ` Junio C Hamano
2010-02-04 23:38             ` Giuseppe Bilotta [this message]
2010-02-05 10:36               ` Johan Herland
2010-02-05 16:10                 ` Junio C Hamano
2010-02-05 21:31                   ` Giuseppe Bilotta
2010-02-05 22:31                   ` Junio C Hamano
2010-02-06  8:16                     ` Giuseppe Bilotta
2010-02-04 21:07         ` Junio C Hamano
2010-02-04 23:20           ` Jakub Narebski
2010-02-05  0:44         ` Jakub Narebski
2010-02-05  0:55           ` Junio C Hamano
2010-02-05  8:42             ` Giuseppe Bilotta
2010-02-05 23:44   ` Jakub Narebski
2010-02-06  9:02     ` Giuseppe Bilotta
2010-02-06 22:14       ` Jakub Narebski
2010-02-06 22:58         ` Giuseppe Bilotta
2010-02-07  1:20           ` Jakub Narebski
2010-02-07  1:38             ` Jakub Narebski
2010-02-07  1:48             ` Johan Herland
2010-02-07 11:08               ` Jakub Narebski
2010-02-07 11:14               ` Giuseppe Bilotta
2010-02-07 12:41                 ` Jakub Narebski
2010-02-07 18:38                   ` Junio C Hamano
2010-02-07 20:11                     ` Giuseppe Bilotta
2010-02-07 21:08                       ` Jakub Narebski
2010-02-07 10:57             ` Giuseppe Bilotta
2010-02-07 11:11               ` Jakub Narebski
2010-02-04 16:18 ` [PATCH 2/4] gitweb: show notes in shortlog view Giuseppe Bilotta
2010-02-06  0:18   ` Jakub Narebski
2010-02-06  9:24     ` Giuseppe Bilotta
2010-02-04 16:18 ` [PATCH 3/4] gitweb: show notes in log Giuseppe Bilotta
2010-02-06 12:57   ` Jakub Narebski
2010-02-06 13:14     ` Giuseppe Bilotta
2010-02-06 21:47       ` Jakub Narebski
2010-02-04 16:18 ` [PATCH 4/4] gitweb: show notes in commit(diff) view Giuseppe Bilotta
2010-02-06 13:16   ` Jakub Narebski
2010-02-06 14:15     ` Giuseppe Bilotta
2010-02-06 14:34       ` Jakub Narebski
2010-02-06 16:13         ` Giuseppe Bilotta
2010-02-06 21:50           ` Jakub Narebski
2010-02-06 22:17             ` Giuseppe Bilotta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb7bb73a1002041538m64c6a6b3p5ee8bbaf0d78457@mail.gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=johan@herland.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).