From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] git-gui: fix worktree initialization with empty prefix
Date: Mon, 22 Feb 2010 16:39:45 +0100 [thread overview]
Message-ID: <cb7bb73a1002220739j1eaae417je9358458f653ef7e@mail.gmail.com> (raw)
In-Reply-To: <vpqsk8t1e1g.fsf@bauges.imag.fr>
On Mon, Feb 22, 2010 at 4:32 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> This is sort of a chicken-and-egg problem, because we should only
>> bother setting the worktree if we are not in a bare repository, but
>> an unset worktree is one of the conditions we check to see if we have
>> a bare repository.
>>
>> Maintain the same sequence of checks, but swap the check for bareness
>> support and bareness of repository, and check again for an unset
>> worktree if we are not in the bare case.
Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> Tested-by: Matthieu Moy <Matthieu.Moy@imag.fr>
>
> (don't forget Signed-off-by)
Damn. Thanks. I just set format.signoff so I won't forget again.
> Thanks,
Thank you for spotting and testing this.
--
Giuseppe "Oblomov" Bilotta
prev parent reply other threads:[~2010-02-22 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 8:27 [BUG] git gui blame: Show History Context broken since 29e5573d Matthieu Moy
2010-02-22 15:18 ` Giuseppe Bilotta
2010-02-22 22:38 ` Heiko Voigt
2010-02-22 23:29 ` Giuseppe Bilotta
2010-02-23 6:40 ` Matthieu Moy
2010-02-23 21:30 ` Re: " Heiko Voigt
2010-02-22 15:19 ` [PATCH] git-gui: fix worktree initialization with empty prefix Giuseppe Bilotta
2010-02-22 15:32 ` Matthieu Moy
2010-02-22 15:39 ` Giuseppe Bilotta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a1002220739j1eaae417je9358458f653ef7e@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).