From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
git <git@vger.kernel.org>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: Re: [BUG] git gui blame: Show History Context broken since 29e5573d
Date: Tue, 23 Feb 2010 00:29:03 +0100 [thread overview]
Message-ID: <cb7bb73a1002221529r6aee3202l5b6609b59aea01fd@mail.gmail.com> (raw)
In-Reply-To: <20100222223802.GA9898@book.hvoigt.net>
On Mon, Feb 22, 2010 at 11:38 PM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> On Mon, Feb 22, 2010 at 04:18:11PM +0100, Giuseppe Bilotta wrote:
>> On Mon, Feb 22, 2010 at 9:27 AM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> > Hi,
>> >
>> > In "git gui blame", right-clicking on the left fringe and chosing
>> > "Show History Context" in the context-menu doesn't work for me in the
>> > latest git. It says:
>> >
>> > couldn't change working directory to "": no such file or directory
>>
>> Definitely my fault. _gitworktree was not being set up correctly when
>> support for bare repositories was enabled and the repo was not bare
>> (like in the blame case). Patch incoming, can you see if it does the
>> job for you? It seems to fix it here.
>
> Isn't this the same bug as this one fixes:
>
> http://article.gmane.org/gmane.comp.version-control.git/140288
>
> cheers Heiko
Interesting, I missed that patch. However, I strongly suspect that
patch is not correct, since in that case the setup of gitworktree is
done before checking for bareness, meaning that when working in
somerepo.git (bare repo) for which the config flag is not set, it
might misdetect the situation as being in the non-bare case. I believe
my fix to be more correct in this regard.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2010-02-22 23:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 8:27 [BUG] git gui blame: Show History Context broken since 29e5573d Matthieu Moy
2010-02-22 15:18 ` Giuseppe Bilotta
2010-02-22 22:38 ` Heiko Voigt
2010-02-22 23:29 ` Giuseppe Bilotta [this message]
2010-02-23 6:40 ` Matthieu Moy
2010-02-23 21:30 ` Re: " Heiko Voigt
2010-02-22 15:19 ` [PATCH] git-gui: fix worktree initialization with empty prefix Giuseppe Bilotta
2010-02-22 15:32 ` Matthieu Moy
2010-02-22 15:39 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a1002221529r6aee3202l5b6609b59aea01fd@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).