From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Markus Heidelberg <markus.heidelberg@web.de>
Cc: Heiko Voigt <hvoigt@hvoigt.net>,
"Shawn O. Pearce" <spearce@spearce.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org,
msysGit Mailinglist <msysgit@googlegroups.com>
Subject: Re: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7
Date: Wed, 24 Feb 2010 07:22:33 +0100 [thread overview]
Message-ID: <cb7bb73a1002232222r354a2ec7l9ea4cfd1c101e8c6@mail.gmail.com> (raw)
In-Reply-To: <201002240114.11634.markus.heidelberg@web.de>
On Wed, Feb 24, 2010 at 1:14 AM, Markus Heidelberg
<markus.heidelberg@web.de> wrote:
>
> Ah, this doesn't look like what it looked like back then. Commit
> 21985a113 (git-gui: handle non-standard worktree locations) changed it,
> removing the [file nativename]. I don't know if this was by accident,
> but there is another place, where it was changed in a different manner:
My fault, and yes it was by accident.
> Compare
>
> - eval exec $explorer [list [file nativename [file dirname [gitdir]]]] &
> + eval exec $explorer $_gitworktree &
>
> with
>
> -wm title . "[appname] ([reponame]) [file normalize [file dirname [gitdir]]]"
> +wm title . "[appname] ([reponame]) [file normalize $_gitworktree]"
>
> Maybe _gitworktree should be normalized or nativenamified when it is set
> and then will work everywhere it is used for every platform?
The only issue with that would be that GIT_DIR and GIT_WORK_TREE are
(re)inizialized
from _gitdir and _gitworktree, so it would not be safe if git on
Windows works better with unix-style rather than native paths. If git
on windows handles native paths fine, it should be no problem.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2010-02-24 6:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 22:52 [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7 Heiko Voigt
2010-02-24 0:14 ` Markus Heidelberg
2010-02-24 6:22 ` Giuseppe Bilotta [this message]
2010-02-24 12:12 ` [msysGit] " Pat Thoyts
2010-02-25 0:14 ` [PATCH] git-gui: fix "Explore Working Copy" for Windows again Markus Heidelberg
2010-02-25 20:44 ` Heiko Voigt
2010-02-25 23:00 ` Pat Thoyts
2010-02-26 0:46 ` Johannes Schindelin
2010-02-27 21:14 ` Heiko Voigt
2010-02-24 12:15 ` [msysGit] [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7 Pat Thoyts
2010-02-25 20:30 ` Heiko Voigt
2010-02-25 22:23 ` [msysGit] " Markus Heidelberg
2010-02-25 22:49 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7bb73a1002232222r354a2ec7l9ea4cfd1c101e8c6@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=markus.heidelberg@web.de \
--cc=msysgit@googlegroups.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).