From: Derrick Stolee <derrickstolee@github.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] CI: add a linux-BUILD-vars job
Date: Wed, 15 Jun 2022 08:41:38 -0400 [thread overview]
Message-ID: <cbba9f52-8ebe-40f2-739e-0796cf60b05c@github.com> (raw)
In-Reply-To: <RFC-patch-3.5-d69368c5b39-20220615T104503Z-avarab@gmail.com>
On 6/15/22 6:53 AM, Ævar Arnfjörð Bjarmason wrote:
> Add a linux-BUILD-vars job, in a preceding commit we fixed a bug that
> would have been spotted by testing under NO_CURL=Y.
You'll want to double-check patch order before sending a full version
for review.
Also, why capitalize "BUILD"? I suppose the variables are all-caps,
but our job names are all lower case to this point, right?
> This CI job attempts to unset various settings in config.mak.uname and
> the Makefile, so that we'll stress our fallbacks and conditionally
> compiled code as much as possible.
I think it is a good idea to include a job that tries these "as
minimal as possible" builds.
> If there is a missing setting here that we can enable under
> "ubuntu-latest" the omission isn't intentional, this list came from a
> quick skimming of the relevant parts of the Makefile and
> config.mak.uname.
We can extend this in the future if we discover something new to add.
The important thing is that this moves us in the right direction.
Thanks,
-Stolee
next prev parent reply other threads:[~2022-06-15 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 10:53 [RFC PATCH 0/5] fix issues in transfer.credentialsInUrl Ævar Arnfjörð Bjarmason
2022-06-15 10:53 ` [RFC PATCH 1/5] push tests: add a missing "test_line_count" Ævar Arnfjörð Bjarmason
2022-06-15 10:53 ` [RFC PATCH 2/5] fetch+push tests: add missing coverage for 6dcbdc0d661 Ævar Arnfjörð Bjarmason
2022-06-15 12:39 ` Derrick Stolee
2022-06-15 10:53 ` [RFC PATCH 3/5] CI: add a linux-BUILD-vars job Ævar Arnfjörð Bjarmason
2022-06-15 12:41 ` Derrick Stolee [this message]
2022-06-15 10:53 ` [RFC PATCH 4/5] fetch: stop emitting duplicate transfer.credentialsInUrl=warn warnings Ævar Arnfjörð Bjarmason
2022-06-15 10:53 ` [RFC PATCH 5/5] transport: check remote.<name>pushurl with transfer.credentialsInUrl Ævar Arnfjörð Bjarmason
2022-06-15 12:52 ` [RFC PATCH 0/5] fix issues in transfer.credentialsInUrl Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbba9f52-8ebe-40f2-739e-0796cf60b05c@github.com \
--to=derrickstolee@github.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).