From: "René Scharfe" <l.s.r@web.de>
To: Git List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] test-ctype: check EOF
Date: Sun, 30 Apr 2023 12:00:01 +0200 [thread overview]
Message-ID: <cbc7feb9-7e15-77e2-b3e9-1fa194b4d4fb@web.de> (raw)
The character classifiers are supposed to handle EOF, a negative integer
value. It isn't part of any character class. Extend the ctype tests to
cover it.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
t/helper/test-ctype.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/t/helper/test-ctype.c b/t/helper/test-ctype.c
index 71a1a5c9b0..039703ee72 100644
--- a/t/helper/test-ctype.c
+++ b/t/helper/test-ctype.c
@@ -2,8 +2,10 @@
static int rc;
-static void report_error(const char *class, int ch)
+static void test(int ch, const char *class, int expect, int actual)
{
+ if (actual == expect)
+ return;
printf("%s classifies char %d (0x%02x) wrongly\n", class, ch, ch);
rc = 1;
}
@@ -24,9 +26,9 @@ static int is_in(const char *s, int ch)
#define TEST_CLASS(t,s) { \
int i; \
for (i = 0; i < 256; i++) { \
- if (is_in(s, i) != t(i)) \
- report_error(#t, i); \
+ test(i, #t, is_in(s, i), t(i)); \
} \
+ test(EOF, #t, 0, t(EOF)); \
}
#define DIGIT "0123456789"
--
2.40.1
next reply other threads:[~2023-04-30 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 10:00 René Scharfe [this message]
2023-05-01 15:23 ` [PATCH] test-ctype: check EOF Junio C Hamano
2023-05-01 19:51 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc7feb9-7e15-77e2-b3e9-1fa194b4d4fb@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).